Code

feature/18-task-sel-filt into develop#32

Code

Merged

JonathanCasey merged 23 commits intodevelopJonathanCasey/asana_extensions:developfrom feature/18-task-sel-filtJonathanCasey/asana_extensions:feature/18-task-sel-filtCopy head branch name to clipboardOct 26, 2021

+1,213-21

Commits

Commits on Oct 23, 2021

• Added get_tasks() to aclient. Started test case -- added to @asana_error_handler test list, started first case of test.

  Show description for c923b34
  JonathanCasey

  committed
  c923b34

• Added rest of unit test for get_tasks(). Passing!

  JonathanCasey

  committed
  9c4dbbc

• Added check against project section in unit test for get_tasks().

  JonathanCasey

  committed
  14b1208

• Added get_filtered_tasks() and _filter_tasks_by_datetime() to autils. No tests yet. Also added new general/utils.py, with is_date_only() checker (with unit test).

  JonathanCasey

  committed
  bb2c387

• Changed _filter_tasks_by_datetime() to handle filling in missing time differently based on whether it is a greater than/eq or a less than/eq check.

  JonathanCasey

  committed
  9874e3c

Commits on Oct 24, 2021

• Added min/max_time_due_assumed (rules config change coming later this issue); added use_tzinfo (rules config change coming NOT in this issue, if ever); timezone factored in for date-only to dif…

  Show description for 87d6e25
  JonathanCasey

  committed
  87d6e25

• Fixed timezone handling and notes...again. Final answer. Unit test for _filter_tasks_by_datetime() finished, with some reordering and extras added to make it easier to use. ...now let's never thi…

  Show description for 234f9d8
  JonathanCasey

  committed
  234f9d8

• Revised test__filter_tasks_by_datetime() to use a list to reduce local vars, make code cleaner.

  JonathanCasey

  committed
  a004a89

• Started test_get_filtered_tasks() with initial assertion testing, no due date cases covered. Added error message to assertion. fixture_sections_in_utl_test() moved to new `/tests/unit/asana/con…

  Show description for 84834af
  JonathanCasey

  committed
  84834af

• Fixed issue where no due date was handled incorrectly (unit tests pay off!). Changed how filtered test results are compared (but no new test cases yet).

  JonathanCasey

  committed
  25c90d6

• Added rest of test cases for get_fitlered_tasks(). Added dt_base arg to that function for unit test purposes.

  JonathanCasey

  committed
  0d1aa36

• Need to also filter tasks based on whether completed -- _filter_tasks_by_completed() added, arg added to get_filtered_tasks(), all unit tests complete.

  JonathanCasey

  committed
  4aa5b0e

• Earlier draft of added parameters to rules.conf.default with a only use datetime field parameter added.

  JonathanCasey

  committed
  1a8fee6

• Changed parse_timedelta_arg() to also return None for an empty string to maximize compatibility with this code.

  JonathanCasey

  committed
  ec84020

• Changed rules.conf.default to use assumed time for min/max due instead of only use datetime field. Added reading and checking of these options in MoveTasksRule, with parse_time_arg() meth…

  Show description for 7a44d23
  JonathanCasey

  committed
  7a44d23

• Fixed pylint error.

  JonathanCasey

  committed
  5ad60f4

• test_parse_time_arg() added to fully unit test the corresponding method in Rule.

  JonathanCasey

  committed
  87cd80e

• Updated MoveTasksRule.load_specific_from_config() unit test with new cases for new keys. Also made test-move-tasks-full a test by itself without counting on it filling in for a specific case --…

  Show description for b9d9256
  JonathanCasey

  committed
  b9d9256

• Fix pylint error.

  JonathanCasey

  committed
  d9dded0

• Add temp debug code to help figure out tests failing only on CI.

  JonathanCasey

  committed
  c64a658

• Removed temp code. Fixed issue due to system not being in EST -- need to use use_tzinfo for most tests. Hopefully successfully added another test case that will work regardless of timezone while …

  Show description for 0329f51
  JonathanCasey

  committed
  0329f51

Commits on Oct 25, 2021

• Tweaked some testing to get better effective test coverage. Still unsure of codecov miss...tested to confirm definitely hitting the line it complained about...

  JonathanCasey

  committed
  4640025

• Changelog updated.

  JonathanCasey

  committed
  270ae32