Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request Review: X-HEEP on ZCU104 #1

Merged
merged 6 commits into from
Jan 5, 2024

Conversation

simone-machetti
Copy link
Collaborator

I implemented the following changes:

  • Fixed GPIO vendorization to avoid the usage of clock-gating cells.
  • Removed constraints file because unused.
  • Updated FPGA top-level wrapper to better differentiate between the 3 supported boards (Pynq-Z2, Nexys, and ZCU104) using defines.
  • Added software target for ZCU104 to set system clock frequency (15 MHz) and UART baud rate (9600).
  • Fixed clock wizard generation script to use the differential 300 MHz input clock.
  • Fixed pin assignment to 1) use the differential 300 MHz input clock; 2) remove comments due to wrong syntax (comments must start with ;#); 3) Rearrange some pins for clearness.

This PR can be merged but does NOT completely fix PR esl-epfl#435. Some additional changes have to be implemented:

  • Fix hold violations in I2S peripheral when implemented on ZCU104.
  • Align and check the correct behavior of Pynq-Z2 and Nexys implementations.

@JoseCalero JoseCalero merged commit 60e5cc9 into JoseCalero:main Jan 5, 2024
2 of 3 checks passed
@simone-machetti simone-machetti deleted the review_pr branch January 10, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants