feat: add dynamic metadata for search results #842
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
maggienegm
force-pushed
the
feat-dynamic-metadata-for-search-results
branch
from
4a2c649 to
e22c518
Compare
maggienegm
force-pushed
the
feat-dynamic-metadata-for-search-results
branch
from
e22c518 to
5ff089f
Compare
|
Just noting for future reference, some test values:
|
|
|
||
| import { metadata as defaultMetadata } from "./layout"; |
There was a problem hiding this comment.
[Non-Actionable] It would be nice if this had an image... but that's definitely out of scope for this PR 😄. Probably a lot more work. I don't even know what that image would look like.
Opinion: someone should file a feature request issue after this suggesting adding image(s) to the metadata. If you want to, awesome - but I can if you don't have time. 🙂
There was a problem hiding this comment.
Great suggestion! I went ahead and created a PR 😄
| }; | ||
| let result: Error | EstimatedPackage[] | undefined; | ||
| export async function generateMetadata({ searchParams }: HomeProps) { | ||
| const { options, result } = await fetchData(searchParams); |
There was a problem hiding this comment.
[Question] Now there are two calls to the Tidelift API per page load 😬. That's probably not ideal? But I don't do enough Next.js app layout code to know the right pattern for this. Do you know if there's a good way to deduplicate? Surely something in Next.js handles this well.
| export async function generateMetadata({ searchParams }: HomeProps) { | ||
| const { options, result } = await fetchData(searchParams); | ||
| const username = options.username || ""; | ||
| const packageCount = Array.isArray(result) ? result.length : 0; |
There was a problem hiding this comment.
[Non-Actionable] Noting from QA: there's no way in the tidelift-me-up package to know that the reason for no packages is that the user didn't exist. Tracked here: JoshuaKGoldberg/tidelift-me-up#17. So, explicitly saying I don't think we need to block the PR on giving a specific description for that. IF you really want to get that in first I'm ok waiting, but otherwise by default I'd just suggest we go with a followup issue. What do you think?
Could not find {username} on npm.
There was a problem hiding this comment.
I agree with not blocking this PR and instead creating a follow up issue to address this bug. I went ahead and created an issue so this can be fixed when the tidelift-me-up package is updated.
JoshuaKGoldberg
added
the
status: waiting for author
PR Checklist
status: accepting prsOverview
This PR introduces dynamic metadata generation for the home/search page. It's metadata is now dynamically generated based on the
searchParamsin the URL:This includes when a valid user has 0 packages eligible for funding based on search parameters. The metadata will look like the following:
When no
searchParamsare provided, the default metadata is used, which is defined inlayout.tsx:Also, something to note is that the API-related logic that was in
page.tsxhas been extracted into a separate file to improve code readability and maintainability.