Do not issue request for undefined hrefs
#34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miyconst
suggested changes
Nov 27, 2017
juicy-html.html
Outdated
| @@ -55,7 +55,7 @@ | |||
| }, | |||
| 'href': { | |||
| set: function(newValue) { | |||
| if(newValue === null){ | |||
| if(newValue === null || newValue === undefined){ | |||
There was a problem hiding this comment.
Please format the code according to our guides, which is default Visual Studio formatting.
if(newValue === null || newValue === undefined){Should be:
if (newValue === null || newValue === undefined) {
juicy-html.html
Outdated
| @@ -67,7 +67,7 @@ | |||
| }, | |||
| 'html': { | |||
| set: function(newValue) { | |||
| if(newValue === null){ | |||
| if(newValue === null || newValue === undefined){ | |||
There was a problem hiding this comment.
Maybe create a function to check for null or undefined value?
alshakero
force-pushed
the
Fix-undefined-uri-request
branch
from
7fbd1f5 to
8e8fb72
Compare
|
Done |
miyconst
approved these changes
Nov 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: Juicy/imported-template#36