Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement Base.copy #104

Merged
merged 1 commit into from
Jun 20, 2022
Merged

implement Base.copy #104

merged 1 commit into from
Jun 20, 2022

Conversation

mzgubic
Copy link
Collaborator

@mzgubic mzgubic commented Jun 20, 2022

Closes #101

julia> @time b + D;
  0.000035 seconds (103 allocations: 29.953 KiB)

The fallback method in Base resorts to looping over eachindex, including the off-diagonal ones.

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #104 (2723bb0) into master (b2ee90a) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   96.11%   95.95%   -0.17%     
==========================================
  Files           5        5              
  Lines         335      321      -14     
==========================================
- Hits          322      308      -14     
  Misses         13       13              
Impacted Files Coverage Δ
src/blockdiagonal.jl 86.15% <100.00%> (-0.21%) ⬇️
src/linalg.jl 95.34% <0.00%> (-0.21%) ⬇️
src/base_maths.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2ee90a...2723bb0. Read the comment docs.

@mzgubic mzgubic merged commit f920f23 into master Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diagonal + blockdiagonal is extremely slow
2 participants