Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert between BlockDiagonals of different block types #105

Merged
merged 2 commits into from
Jun 22, 2022
Merged

Conversation

mzgubic
Copy link
Collaborator

@mzgubic mzgubic commented Jun 20, 2022

Helps with #102

The idea is that if

julia> convert(Matrix, Symmetric(rand(2, 2)))

is allowed, then so should convert between BlockDiagonals where the blocks are of these types, e.g.

julia> convert(BlockDiagonal{Float64, Matrix{Float64}}, BlockDiagonal([Symmetric(rand(2, 2))]))

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #105 (650b6ed) into master (b2ee90a) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage   96.11%   95.98%   -0.14%     
==========================================
  Files           5        5              
  Lines         335      324      -11     
==========================================
- Hits          322      311      -11     
  Misses         13       13              
Impacted Files Coverage Δ
src/blockdiagonal.jl 86.76% <100.00%> (+0.40%) ⬆️
src/linalg.jl 95.34% <0.00%> (-0.21%) ⬇️
src/base_maths.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2ee90a...650b6ed. Read the comment docs.

@mzgubic mzgubic merged commit 1ab40c9 into master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants