Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiply BlockDiagonal with JuMP AffExpr #89

Closed
wants to merge 1 commit into from
Closed

Conversation

fchorney
Copy link
Contributor

Add a function to multiply BlockDiagonal with JuMP Vector{AffExpr} so we don't need to wrap a BlockDiagonal in a Matrix first.

Is there a way to make the tests simpler?

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #89 (ab60e80) into master (0b98861) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   96.09%   95.92%   -0.18%     
==========================================
  Files           5        6       +1     
  Lines         333      319      -14     
==========================================
- Hits          320      306      -14     
  Misses         13       13              
Impacted Files Coverage Δ
src/BlockDiagonals.jl 100.00% <ø> (ø)
src/jump.jl 100.00% <100.00%> (ø)
src/blockdiagonal.jl 85.93% <0.00%> (-0.63%) ⬇️
src/linalg.jl 95.18% <0.00%> (-0.23%) ⬇️
src/base_maths.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b98861...ab60e80. Read the comment docs.

@mzgubic
Copy link
Collaborator

mzgubic commented May 11, 2022

What's the context for this? I don't think this package wants to depend on JuMP?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants