promote_type when multiplying BlockDiagonal with vectors and matrices
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 12, 2022 12:23
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 95.91% 95.92% +0.01%
==========================================
Files 5 5
Lines 318 319 +1
==========================================
+ Hits 305 306 +1
Misses 13 13
Continue to review full report at Codecov.
|
|
@fchorney could you review this please? |
fchorney
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #92, closes #90
Should remove the need for #89.
@fchorney does it work for your use case?