Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

master breaks GaussianProcesses (tagging logjam) #548

Closed
timholy opened this issue Nov 19, 2018 · 0 comments
Closed

master breaks GaussianProcesses (tagging logjam) #548

timholy opened this issue Nov 19, 2018 · 0 comments

Comments

@timholy
Copy link
Member

timholy commented Nov 19, 2018

JuliaLang/METADATA.jl#19433 can't be merged because of a regression in GaussianProcesses. The error comes down to not finding a method for similar(::StaticArrays.SArray{Tuple{1},Int64,1,1}, ::Tuple{Base.Slice{StaticArrays.SOneTo{1}}}).

Fortunately, Base.Slice{SOneTo} is conceptually equivalent to SOneTo, so I don't think there's any problem supporting this operation. Fix on the way, once I verify that the GaussianProcesses tests pass.
timholy added a commit that referenced this issue Nov 19, 2018
@timholy
Merge pull request #549 from JuliaArrays/teh/fix_548
d14604c 
Support Base.Slice axes (fixes #548)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timholy