Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Julia v0.7 support, remove deprecations #525

Closed
wants to merge 1 commit into from

Conversation

andyferris
Copy link
Member

We have a solid release for Julia v0.7, which should be good enough for users needing to upgrade to v1.0. Personally, I don't feel it is valuable keeping around the old fluff.

I'm interested in getting this in for #522

@andyferris andyferris mentioned this pull request Oct 23, 2018
2 tasks
@andyferris
Copy link
Member Author

FYI, I kept the deprecations for #515 and #521, since there is no release with those.

Copy link
Member

@c42f c42f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we release StaticArrays-0.9 before merging this? That way people can have consistent functionality in StaticArrays-0.9 in both julia-0.7 and julia-1.0? (And you could also remove the deprecations from #515 and #521 in this PR.)

@andyferris
Copy link
Member Author

That way people can have consistent functionality in StaticArrays-0.9 in both julia-0.7 and julia-1.0?

Consistent? The idea here was that julia-0.7 users wouldn't be able to install StaticArrays-0.9. StaticArrays-0.8 provides a consistent, upgrade layer.

Is it more that the bugs fixed in StaticArrays-0.9 will be important enough to include for users simply upgrading their Julia-0.6 code to Julia-1.0?

@c42f
Copy link
Member

c42f commented Oct 23, 2018

Yes, there's bugs fixed in StaticArrays-0.9; they're minor but did break my own code when upgrading from 0.6.

My point is, we loose very little by delaying the removal of these potentially helpful deprecations (and the ability to install a more 0.6 compatible version on 0.7) by another release. And it could be rather helpful for other package maintainers.

Just a thought, no major worries if it's merged right away.

@andyferris
Copy link
Member Author

OK - if it's useful, then it's useful!

@mschauer
Copy link
Collaborator

Can we remove the deprecation warnings without bumping the required version? I suppose the new release will run just fine on 0.7. (I prefer my coworkers using 0.7 for the time being, that makes it easier for me to help them and for them to help themselves using stackoverflow etc.)

@c42f
Copy link
Member

c42f commented Oct 23, 2018

@mschauer I think that's quite reasonable. That will let users who are on 0.7 continue to get StaticArrays related bugfixes.

The only downside being that the depwarns won't be consistent with Base 0.7 related depwarns. But I think that's a reasonable tradeoff.

@c42f c42f mentioned this pull request Oct 27, 2018
18 tasks
@c42f c42f added this to the 1.0 milestone Oct 31, 2018
@c42f
Copy link
Member

c42f commented Apr 18, 2019

Partially obsoleted by #600 (though I didn't drop 0.7 support there)

@mschauer
Copy link
Collaborator

My earlier objection is obsolete now, in any case.

@fredrikekre fredrikekre mentioned this pull request Apr 18, 2019
@c42f c42f closed this in #601 Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants