Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop 0.7 #601

Merged
merged 3 commits into from
Apr 26, 2019
Merged

Drop 0.7 #601

merged 3 commits into from
Apr 26, 2019

Conversation

fredrikekre
Copy link
Member

closes #525 by replacing it.

@coveralls
Copy link

Coverage Status

Coverage increased (+13.8%) to 81.1% when pulling 2f541ed on fe/fixes into 13a25d9 on master.

@c42f
Copy link
Member

c42f commented Apr 23, 2019

This looks like a bunch of good cleanup for stuff which was required during the 0.7 dev cycle.

But do we actually need to drop 0.7 itself here? Is anything significant gained by doing so?

@fredrikekre
Copy link
Member Author

But do we actually need to drop 0.7 itself here? Is anything significant gained by doing so?

Same reason Julia 0.7 and 1.0 are different versions -- when you are on 0.7 you should get a StaticArrays release with deprecations. Thus, the next StaticArrays release without deprecations should not be installable on Julia 0.7.

@c42f
Copy link
Member

c42f commented Apr 24, 2019

Hmm. I don't think packages are or generally can be consistent about synchronizing their deprecations with julia releases. Though it seems fair to argue that StaticArrays is sufficiently similar to Base that this provides some value.

@mschauer has expressed concern about dropping 0.7 before, but at this stage StaticArrays has been pretty stable for a while and 0.7/1.0 is rapidly receding into the past. What do you think Moritz?

@fredrikekre
Copy link
Member Author

I don't think packages are or generally can be consistent about synchronizing their deprecations with julia releases

I agree in general, but in this case the StaticArrays deprecations match the deprecations for Julia.

Copy link
Member

@andyferris andyferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this.

Copy link
Collaborator

@mschauer mschauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections

@c42f c42f merged commit d3f739e into master Apr 26, 2019
@c42f
Copy link
Member

c42f commented Apr 26, 2019

Cool let's go with this.

@fredrikekre fredrikekre deleted the fe/fixes branch April 26, 2019 04:51
@c42f c42f mentioned this pull request Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants