Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we test on 1.5 #840

Closed
wants to merge 1 commit into from
Closed

Ensure we test on 1.5 #840

wants to merge 1 commit into from

Conversation

c42f
Copy link
Member

@c42f c42f commented Oct 18, 2020

@andyferris
Copy link
Member

Why do the tests take so long?

@c42f
Copy link
Member Author

c42f commented Oct 19, 2020

Wow, that failure on windows is concerning. Somehow we've got a C++ exception getting reported there, along with a Julia stack trace. It looks like the program ran out of memory in some C++ code (presumably the Julia runtime?) and threw std::bad_alloc, leading to abort being called https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/abort?view=vs-2019 and returning an exit code of 3.

signal (22): SIGABRT
in expression starting at D:\a\StaticArrays.jl\StaticArrays.jl\test\lu.jl:51
raise at C:\windows\System32\msvcrt.dll (unknown line)
abort at C:\windows\System32\msvcrt.dll (unknown line)
ZN9__gnu_cxx27__verbose_terminate_handlerEv at C:\hostedtoolcache\windows\julia\1.5.2\x86\bin\libstdc++-6.dll (unknown line)
ZGTtNSt16invalid_argumentD2Ev at C:\hostedtoolcache\windows\julia\1.5.2\x86\bin\libstdc++-6.dll (unknown line)
ZGTtNSt16invalid_argumentD2Ev at C:\hostedtoolcache\windows\julia\1.5.2\x86\bin\libstdc++-6.dll (unknown line)
Allocations: 2805643639 (Pool: 2805283867; Big: 359772); GC: 1229
terminate called after throwing an instance of 'std::bad_alloc'
  what():  std::bad_alloc
ERROR: Package StaticArrays errored during testing (exit code: 3)
Stacktrace:
 [1] pkgerror(::String) at D:\buildbot\worker\package_win32\build\usr\share\julia\stdlib\v1.5\Pkg\src\Types.jl:52
 [2] test(::Pkg.Types.Context, ::Array{Pkg.Types.PackageSpec,1}; coverage::Bool, julia_args::Cmd, test_args::Cmd, test_fn::Nothing) at D:\buildbot\worker\package_win32\build\usr\share\julia\stdlib\v1.5\Pkg\src\Operations.jl:1578
 [3] test(::Pkg.Types.Context, ::Array{Pkg.Types.PackageSpec,1}; coverage::Bool, test_fn::Nothing, julia_args::Cmd, test_args::Cmd, kwargs::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}) at D:\buildbot\worker\package_win32\build\usr\share\julia\stdlib\v1.5\Pkg\src\API.jl:327
 [4] #test#61 at D:\buildbot\worker\package_win32\build\usr\share\julia\stdlib\v1.5\Pkg\src\API.jl:67 [inlined]
 [5] test(; name::Nothing, uuid::Nothing, version::Nothing, url::Nothing, rev::Nothing, path::Nothing, mode::Pkg.Types.PackageMode, subdir::Nothing, kwargs::Base.Iterators.Pairs{Symbol,Bool,Tuple{Symbol},NamedTuple{(:coverage,),Tuple{Bool}}}) at D:\buildbot\worker\package_win32\build\usr\share\julia\stdlib\v1.5\Pkg\src\API.jl:80
 [6] top-level scope at none:1
Error: Process completed with exit code 1.

Why do the tests take so long?

I think because we stress the compiler a lot by compiling so many specializations. The LU tests alone take 60 s on my machine.

@c42f
Copy link
Member Author

c42f commented Oct 19, 2020

The ubuntu failures on nightly are some oddities I've seen before (in unrelated packages)... some weird error during git cloning the package.

@c42f
Copy link
Member Author

c42f commented Oct 19, 2020

Nightly failure during git clone reported at julia-actions/julia-buildpkg#7

@c42f
Copy link
Member Author

c42f commented Oct 23, 2020

Well, it seems this regularly runs out of memory on windows with Julia 1.5. Whether that's because the testing environment is very memory limited, or we've got some horrible bug is unclear.

Need to test on a windows box...

@c42f
Copy link
Member Author

c42f commented Nov 27, 2020

I ran manually on windows with julia 1.5.3 and tests passed. So I think the errors here are likely due to the test environment resources.

@mateuszbaran
Copy link
Collaborator

This was handled in #928 so I think we can close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants