-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run CI on latest released 1.x version #928
Conversation
Huh, seems this didn't quite fix #925. Not sure if this isn't really a bug in Julia instead. Specifically, if we define: julia> using StaticArrays, Test, LinearAlgebra
julia> m_sing2 = @SMatrix [1 1; 1 0; 0 1];
julia> svd_full_false(A) = svd(A, full=false); and consult julia> @code_warntype svd_full_false(m_sing2)
Variables
#self#::Core.Const(svd_full_false)
A::SMatrix{3, 2, Int64, 6}
Body::StaticArrays.SVD{Float64, SMatrix{3, 2, Float64, 6}, SVector{2, Float64}, SMatrix{2, 2, Float64, 4}}
1 ─ %1 = (:full,)::Core.Const((:full,))
│ %2 = Core.apply_type(Core.NamedTuple, %1)::Core.Const(NamedTuple{(:full,), T} where T<:Tuple)
│ %3 = Core.tuple(false)::Core.Const((false,))
│ %4 = (%2)(%3)::Core.Const((full = false,))
│ %5 = Core.kwfunc(Main.svd)::Core.Const(LinearAlgebra.var"#svd##kw"())
│ %6 = (%5)(%4, Main.svd, A)::StaticArrays.SVD{Float64, SMatrix{3, 2, Float64, 6}, SVector{2, Float64}, SMatrix{2, 2, Float64, 4}}
└── return %6 But julia> @inferred svd_full_false(m_sing2)
ERROR: return type StaticArrays.SVD{Float64, SMatrix{3, 2, Float64, 6}, SVector{2, Float64}, SMatrix{2, 2, Float64, 4}} does not match inferred return type Union{StaticArrays.SVD{Float64, SMatrix{3, 2, Float64, 6}, SVector{2, Float64}, SMatrix{2, 2, Float64, 4}}, StaticArrays.SVD{Float64, SMatrix{3, 3, Float64, 9}, SVector{2, Float64}, SMatrix{2, 2, Float64, 4}}}
Stacktrace:
[1] error(s::String)
@ Base ./error.jl:33
[2] top-level scope
@ REPL[19]:1 (Edit: this difference between Pretty sure I even had one REPL session where |
Okay; I just |
…d `@test_broken` for `abstractarray.jl` tests
This now also changes a few That's basically unrelated to this PR - but I just wanted to see if I could get the nightly CI passing (sadly, there were more issues down the line - I'm going to leave them for now). |
Great, thanks. @mateuszbaran can this be merged? It would be nice to have StaticArrays test pass on latest release or otherwise regressions won't be noticed by PkgEval for upcoming releases (e.g. 1.7). |
Yes, right, I'll merge this. I think this doesn't require a new release because only tests are changed. |
True but unless it gets a release PkgEval won't pick it up. However, there might be other things that will require a release soon anyway, like the |
Yes, I think both that |
#932 should fix the |
* Run CI on latest released 1.x version * fix broken tests on v1.6+ * disable `svd` kwarg const-prop test on v1.6 and later * mark `svd` test as broken on v1.6 and later & swap between `@test` and `@test_broken` for `abstractarray.jl` tests
I noticed that CI wasn't running on 1.6, which I figured would be a good idea, even if it increases the run-time.
With this PR, it still doesn't run on 1.5, and won't run on 1.6 after 1.7 is released (then it'll run on 1.7) - but it seems better than not to run at all, and doesn't increase CI time very much compared to adding everything.