only use apple-m1 target for macos #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
commented
May 17, 2024
| JUlIA_CPU_TARGETS=() | ||
| JULIA_CPU_TARGETS=() |
There was a problem hiding this comment.
How was this not failing??
There was a problem hiding this comment.
Because bash doesn't have problems with += for an undefined variable. I don't know if there's a mode to turn that into an error, set -u doesn't seem to help here.
giordano
reviewed
May 17, 2024
| "thunderx2t99" | ||
| # NVidia Carmel, e.g. Jetson AGX Xavier; serves as a baseline for later architectures | ||
| "carmel,clone_all" | ||
| # Vector-length-agnostic common denominator between Neoverse V1 and V2, recent Arm server architectures |
There was a problem hiding this comment.
ah-sorry (asahi), I forgot about using other OSs on macs
There was a problem hiding this comment.
I haven't checked carefully, but it may also be usable by Neoverse (since the neoverse-512tvb target isn't doing anything right now)
|
Does this look alright @staticfloat @gbaraldi ? |
staticfloat
approved these changes
May 23, 2024
|
Looks like CI was failing in this PR, because the tree hashes needed to be re-signed. |
DilumAluthge
added a commit
that referenced
this pull request
May 23, 2024
This reverts commit 0c1c585.
DilumAluthge
added a commit
that referenced
this pull request
May 23, 2024
|
I've reverted this PR in #355, to get Julia master green again. |
IanButterworth
added a commit
that referenced
this pull request
Jun 9, 2024
IanButterworth
added a commit
that referenced
this pull request
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came up as part of JuliaLang/julia#54471
Master
MacOS aarch64: 5m55s 214 MB artifact
This PR
MacOS aarch64: 5m5s 197 MB artifact