Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only use apple-m1 target for macos #354

Merged
merged 5 commits into from
May 23, 2024
Merged

only use apple-m1 target for macos #354

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dbff39e
only use apple-m1 target for macos
IanButterworth May 17, 2024
dccebe7
fix typo
IanButterworth May 17, 2024
f0f2605
fixup
IanButterworth May 17, 2024
6f2306e
fix
IanButterworth May 17, 2024
36b51d7
add apple-m1 back to other aarch64 OSs
IanButterworth May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 25 additions & 15 deletions utilities/build_envs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ if buildkite-agent meta-data exists BUILDKITE_JULIA_BRANCH; then
fi

# Determine JULIA_CPU_TARGETS for different architectures
JUlIA_CPU_TARGETS=()
JULIA_CPU_TARGETS=()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was this not failing??

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because bash doesn't have problems with += for an undefined variable. I don't know if there's a mode to turn that into an error, set -u doesn't seem to help here.

case "${ARCH?}" in
x86_64)
JULIA_CPU_TARGETS+=(
Expand Down Expand Up @@ -54,20 +54,30 @@ case "${ARCH?}" in
)
;;
aarch64)
JULIA_CPU_TARGETS+=(
# Absolute base aarch64 feature set
"generic"
# Cortex A57, Example: NVIDIA Jetson TX1, Jetson Nano
"cortex-a57"
# Cavium ThunderX2T99, a common server architecture
"thunderx2t99"
# NVidia Carmel, e.g. Jetson AGX Xavier; serves as a baseline for later architectures
"carmel,clone_all"
# Apple M1
"apple-m1,base(3)"
# Vector-length-agnostic common denominator between Neoverse V1 and V2, recent Arm server architectures
"neoverse-512tvb,base(3)"
)
case "${OS?}" in
macos)
JULIA_CPU_TARGETS+=(
# Absolute base aarch64 feature set
"generic"
# Apple M1
"apple-m1,base(3)"
)
;;
*)
JULIA_CPU_TARGETS+=(
# Absolute base aarch64 feature set
"generic"
# Cortex A57, Example: NVIDIA Jetson TX1, Jetson Nano
"cortex-a57"
# Cavium ThunderX2T99, a common server architecture
"thunderx2t99"
# NVidia Carmel, e.g. Jetson AGX Xavier; serves as a baseline for later architectures
"carmel,clone_all"
# Vector-length-agnostic common denominator between Neoverse V1 and V2, recent Arm server architectures
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not apple-m1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah-sorry (asahi), I forgot about using other OSs on macs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked carefully, but it may also be usable by Neoverse (since the neoverse-512tvb target isn't doing anything right now)

"neoverse-512tvb,base(3)"
)
;;
esac
;;
powerpc64le)
JULIA_CPU_TARGETS+=(
Expand Down