AWS API Definitions Updated

[github-actions]

Automated changes by create-pull-request GitHub action

[mortenpi]

Could this be merged and tagged? I noticed that AWS.jl doesn't have all the newest actions anymore (like SESv2 GetMessageInsights).

[ararslan]

There's a lot of history that's collapsed by default but of note are #637 (comment) and #637 (comment). I agree it'd be nice to have it merged.

[mortenpi]

Ah, yea, I did not check if there were any comments there.

For the formatting, I suggest we downgrade JuliaFormatter for the time being (#676). I think that should reduce the diff here.

It does look like the new formatting of those function definitions better matches the generated code, so it feels like the new JuliaFormatter is doing the right thing here.

AWS.jl/src/api_generation/high_level.jl

Lines 153 to 179 in 5ebf8ca

	if required_keys && (idempotent || headers)
	return """
	$formatted_function_name($(join(req_keys, ", ")); aws_config::AbstractAWSConfig=global_aws_config()) = $service_name(\"$method\", \"$request_uri\", $params_headers_str; aws_config=aws_config, feature_set=SERVICE_FEATURE_SET)
	$formatted_function_name($(join(req_keys, ", ")), params::AbstractDict{String}; aws_config::AbstractAWSConfig=global_aws_config()) = $service_name(\"$method\", \"$request_uri\", Dict{String, Any}(mergewith(_merge, $params_headers_str, params)); aws_config=aws_config, feature_set=SERVICE_FEATURE_SET)
	"""
	elseif !required_keys && (idempotent || headers)
	return """
	$formatted_function_name(; aws_config::AbstractAWSConfig=global_aws_config()) = $service_name(\"$method\", \"$request_uri\", $params_headers_str; aws_config=aws_config, feature_set=SERVICE_FEATURE_SET)
	$formatted_function_name(params::AbstractDict{String}; aws_config::AbstractAWSConfig=global_aws_config()) = $service_name(\"$method\", \"$request_uri\", Dict{String, Any}(mergewith(_merge, $params_headers_str, params)); aws_config=aws_config, feature_set=SERVICE_FEATURE_SET)
	"""
	elseif required_keys && !isempty(req_kv)
	return """
	$formatted_function_name($(join(req_keys, ", ")); aws_config::AbstractAWSConfig=global_aws_config()) = $service_name(\"$method\", \"$request_uri\", $req_str); aws_config=aws_config, feature_set=SERVICE_FEATURE_SET)
	$formatted_function_name($(join(req_keys, ", ")), params::AbstractDict{String}; aws_config::AbstractAWSConfig=global_aws_config()) = $service_name(\"$method\", \"$request_uri\", Dict{String, Any}(mergewith(_merge, $req_str), params)); aws_config=aws_config, feature_set=SERVICE_FEATURE_SET)
	"""
	elseif required_keys
	return """
	$formatted_function_name($(join(req_keys, ", ")); aws_config::AbstractAWSConfig=global_aws_config()) = $service_name(\"$method\", \"$request_uri\"; aws_config=aws_config, feature_set=SERVICE_FEATURE_SET)
	$formatted_function_name($(join(req_keys, ", ")), params::AbstractDict{String}; aws_config::AbstractAWSConfig=global_aws_config()) = $service_name(\"$method\", \"$request_uri\", params; aws_config=aws_config, feature_set=SERVICE_FEATURE_SET)
	"""
	else
	return """
	$formatted_function_name(; aws_config::AbstractAWSConfig=global_aws_config()) = $service_name(\"$method\", \"$request_uri\"; aws_config=aws_config, feature_set=SERVICE_FEATURE_SET)
	$formatted_function_name(params::AbstractDict{String}; aws_config::AbstractAWSConfig=global_aws_config()) = $service_name(\"$method\", \"$request_uri\", params; aws_config=aws_config, feature_set=SERVICE_FEATURE_SET)
	"""
	end
	end

But I think we could get the substantial changes here merged first, and then just do a trivial formatting PR afterwards.

[ararslan]

It does look like the new formatting of those function definitions better matches the generated code, so it feels like the new JuliaFormatter is doing the right thing here.

Yeah I suppose it does better match the way the generated code is written, but the change seems like a bug to me; IIUC, BlueStyle is supposed to have short_to_long_function_def = true by default, which should have turned any short-form definition into a long-form (i.e. with a function block) definition when the line length exceeds 92-characters.

[ararslan]

The diff here has been reduced very significantly thanks to @mortenpi; the remaining changes should now be reflective of actual AWS changes. @mattBrzezinski, given that the SQS change from QueryService to JSONService is expected, is there anything barring merging this? I suppose there's likely been further changes pushed to this PR since you last looked, do you think you'd have time to give it another look, or is there anything others can do to support that?

[mattBrzezinski]

The diff here has been reduced very significantly thanks to @mortenpi; the remaining changes should now be reflective of actual AWS changes. @mattBrzezinski, given that the SQS change from QueryService to JSONService is expected, is there anything barring merging this? I suppose there's likely been further changes pushed to this PR since you last looked, do you think you'd have time to give it another look, or is there anything others can do to support that?

Sorry just seeing this now! I can take a pass over this, merge it and tag the new version.

To be honest, I don't have the time day-to-day to work on OSS; nor a desire to spend my free time on it. I am happy to add folks to the organization if they would like to take some ownership over the package, and give an in-depth walkthrough of how it works if desired.

[ararslan]

Thanks, @mattBrzezinski!

I don't have the time day-to-day to work on OSS

Extremely relatable

I am happy to add folks to the organization if they would like to take some ownership over the package, and give an in-depth walkthrough of how it works if desired.

It could be worth posting a call for maintainers on Discourse and perhaps link to that in the Julia Slack.