Fix SQS tests assuming the query service response structure #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PR 637, SQS changed from a `QueryService` to a `JSONService`. The response obtained when interacting with SQS using the query protocol includes a field called `<ActionName>Result`, where `<ActionName>` is the action requested. The JSON protocol does not include that field. Thus we can fix issue 683 by simply deleting that additional `getindex` call.
mattBrzezinski
approved these changes
Jul 2, 2024
|
This fixes the SQS failures that were the original scope of the PR, though there's still the credential loading failure, so this doesn't fully fix #683 as is. Still better than the status quo so I'll go ahead and merge and the credential thing can be addressed separately. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #637, SQS changed from a
QueryServiceto aJSONService(expectedly). The response obtained when interacting with SQS using the query protocol includes a field called<ActionName>Result, where<ActionName>is the action requested. The JSON protocol does not include that field. Thus I believe we can fix (or at least partially fix) #683 by simply deleting that additionalgetindexcall.