Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Route53 endpoint no longer working #107

Closed
mattBrzezinski opened this issue Jan 27, 2020 · 1 comment
Closed

Route53 endpoint no longer working #107

mattBrzezinski opened this issue Jan 27, 2020 · 1 comment

Comments

@mattBrzezinski
Copy link
Member

Original Issue: JuliaCloud/AWSSDK.jl#13

The AWSCLI submits requests to: route53.amazonaws.com, while AWSCore.jl will try to submit to route-53-${Region}.amazonaws.com which ends up failing.

The problem stems from this bit of code, here which needs to be changed to special case route53 (and possibly other AWS Services).
This was referenced Jan 27, 2020
Closed
Merged
bors bot added a commit that referenced this issue Jan 28, 2020
@bors @mattBrzezinski
Merge #108
afc2ea7 
108: Set region to nothing for Route53 endpoint when making service URL r=mattBrzezinski a=mattBrzezinski

**Resolves:** #107 

## Current Behaviour
Currently when making a request to `route53` the URL which we hit is `route53.us-east-1.amazonaws.com`, this is not a valid endpoint and results in a `DNSError` being thrown.

## Expected Behaviour
We currently special case one region less service `sdb`, I've made this into a list of strings and tacked in `route53` as well.

Now when you run the code example the request goes through successfully.

## Code Example
```julia
using AWSCore.Services: route53
route53("GET", "/2013-04-01/accountlimit/MAX_HEALTH_CHECKS_BY_OWNER")

# ERROR: DNSError: route53.us-east-1.amazonaws.com, unknown node or service (EAI_NONAME)
```

Co-authored-by: Matt Brzezinski <matt.brzezinski@invenia.ca>
bors bot added a commit that referenced this issue Jan 28, 2020
@bors @mattBrzezinski
Merge #108
81c8971 
108: Set region to nothing for Route53 endpoint when making service URL r=mattBrzezinski a=mattBrzezinski

**Resolves:** #107 

## Current Behaviour
Currently when making a request to `route53` the URL which we hit is `route53.us-east-1.amazonaws.com`, this is not a valid endpoint and results in a `DNSError` being thrown.

## Expected Behaviour
We currently special case one region less service `sdb`, I've made this into a list of strings and tacked in `route53` as well.

Now when you run the code example the request goes through successfully.

## Code Example
```julia
using AWSCore.Services: route53
route53("GET", "/2013-04-01/accountlimit/MAX_HEALTH_CHECKS_BY_OWNER")

# ERROR: DNSError: route53.us-east-1.amazonaws.com, unknown node or service (EAI_NONAME)
```

Co-authored-by: Matt Brzezinski <matt.brzezinski@invenia.ca>
bors bot added a commit that referenced this issue Jan 28, 2020
@bors @mattBrzezinski
Merge #108
56e97a6 
108: Set region to nothing for Route53 endpoint when making service URL r=mattBrzezinski a=mattBrzezinski

**Resolves:** #107 

## Current Behaviour
Currently when making a request to `route53` the URL which we hit is `route53.us-east-1.amazonaws.com`, this is not a valid endpoint and results in a `DNSError` being thrown.

## Expected Behaviour
We currently special case one region less service `sdb`, I've made this into a list of strings and tacked in `route53` as well.

Now when you run the code example the request goes through successfully.

## Code Example
```julia
using AWSCore.Services: route53
route53("GET", "/2013-04-01/accountlimit/MAX_HEALTH_CHECKS_BY_OWNER")

# ERROR: DNSError: route53.us-east-1.amazonaws.com, unknown node or service (EAI_NONAME)
```

Co-authored-by: Matt Brzezinski <matt.brzezinski@invenia.ca>
bors bot added a commit that referenced this issue Jan 28, 2020
@bors @mattBrzezinski
Merge #108
9cd1ec2 
108: Set region to nothing for Route53 endpoint when making service URL r=mattBrzezinski a=mattBrzezinski

**Resolves:** #107 

## Current Behaviour
Currently when making a request to `route53` the URL which we hit is `route53.us-east-1.amazonaws.com`, this is not a valid endpoint and results in a `DNSError` being thrown.

## Expected Behaviour
We currently special case one region less service `sdb`, I've made this into a list of strings and tacked in `route53` as well.

Now when you run the code example the request goes through successfully.

## Code Example
```julia
using AWSCore.Services: route53
route53("GET", "/2013-04-01/accountlimit/MAX_HEALTH_CHECKS_BY_OWNER")

# ERROR: DNSError: route53.us-east-1.amazonaws.com, unknown node or service (EAI_NONAME)
```

Co-authored-by: Matt Brzezinski <matt.brzezinski@invenia.ca>
bors bot added a commit that referenced this issue Jan 29, 2020
@bors @mattBrzezinski
Merge #108
114ad6f 
108: Set region to nothing for Route53 endpoint when making service URL r=mattBrzezinski a=mattBrzezinski

**Resolves:** #107 

## Current Behaviour
Currently when making a request to `route53` the URL which we hit is `route53.us-east-1.amazonaws.com`, this is not a valid endpoint and results in a `DNSError` being thrown.

## Expected Behaviour
We currently special case one region less service `sdb`, I've made this into a list of strings and tacked in `route53` as well.

Now when you run the code example the request goes through successfully.

## Code Example
```julia
using AWSCore.Services: route53
route53("GET", "/2013-04-01/accountlimit/MAX_HEALTH_CHECKS_BY_OWNER")

# ERROR: DNSError: route53.us-east-1.amazonaws.com, unknown node or service (EAI_NONAME)
```

Co-authored-by: Matt Brzezinski <matt.brzezinski@invenia.ca>
bors bot added a commit that referenced this issue Jan 29, 2020
@bors @mattBrzezinski
Merge #108
055f12e 
108: Set region to nothing for Route53 endpoint when making service URL r=mattBrzezinski a=mattBrzezinski

**Resolves:** #107 

## Current Behaviour
Currently when making a request to `route53` the URL which we hit is `route53.us-east-1.amazonaws.com`, this is not a valid endpoint and results in a `DNSError` being thrown.

## Expected Behaviour
We currently special case one region less service `sdb`, I've made this into a list of strings and tacked in `route53` as well.

Now when you run the code example the request goes through successfully.

## Code Example
```julia
using AWSCore.Services: route53
route53("GET", "/2013-04-01/accountlimit/MAX_HEALTH_CHECKS_BY_OWNER")

# ERROR: DNSError: route53.us-east-1.amazonaws.com, unknown node or service (EAI_NONAME)
```

Co-authored-by: Matt Brzezinski <matt.brzezinski@invenia.ca>
bors bot added a commit that referenced this issue Jan 29, 2020
@bors @mattBrzezinski
Merge #108
0da160a 
108: Set region to nothing for Route53 endpoint when making service URL r=mattBrzezinski a=mattBrzezinski

**Resolves:** #107 

## Current Behaviour
Currently when making a request to `route53` the URL which we hit is `route53.us-east-1.amazonaws.com`, this is not a valid endpoint and results in a `DNSError` being thrown.

## Expected Behaviour
We currently special case one region less service `sdb`, I've made this into a list of strings and tacked in `route53` as well.

Now when you run the code example the request goes through successfully.

## Code Example
```julia
using AWSCore.Services: route53
route53("GET", "/2013-04-01/accountlimit/MAX_HEALTH_CHECKS_BY_OWNER")

# ERROR: DNSError: route53.us-east-1.amazonaws.com, unknown node or service (EAI_NONAME)
```

Co-authored-by: Matt Brzezinski <matt.brzezinski@invenia.ca>
@mattBrzezinski
Copy link
Member Author

Resolved in #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattBrzezinski