Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set region to nothing for Route53 endpoint when making service URL #108

Merged
merged 3 commits into from
Jan 29, 2020
Merged

Set region to nothing for Route53 endpoint when making service URL #108

merged 3 commits into from
Jan 29, 2020

Conversation

mattBrzezinski
Copy link
Member

Resolves: #107

Current Behaviour

Currently when making a request to route53 the URL which we hit is route53.us-east-1.amazonaws.com, this is not a valid endpoint and results in a DNSError being thrown.

Expected Behaviour

We currently special case one region less service sdb, I've made this into a list of strings and tacked in route53 as well.

Now when you run the code example the request goes through successfully.

Code Example

using AWSCore.Services: route53
route53("GET", "/2013-04-01/accountlimit/MAX_HEALTH_CHECKS_BY_OWNER")

# ERROR: DNSError: route53.us-east-1.amazonaws.com, unknown node or service (EAI_NONAME)

omus
omus reviewed Jan 28, 2020
View reviewed changes
src/AWSCore.jl Outdated Show resolved Hide resolved
src/AWSCore.jl Outdated Show resolved Hide resolved
test/endpoints.jl Outdated Show resolved Hide resolved
src/AWSCore.jl Outdated Show resolved Hide resolved
src/AWSCore.jl Outdated Show resolved Hide resolved
@mattBrzezinski

This comment has been minimized.

Sign in to view
bors bot added a commit that referenced this pull request Jan 28, 2020
@bors @mattBrzezinski
Merge #108
afc2ea7 
108: Set region to nothing for Route53 endpoint when making service URL r=mattBrzezinski a=mattBrzezinski

**Resolves:** #107 

## Current Behaviour
Currently when making a request to `route53` the URL which we hit is `route53.us-east-1.amazonaws.com`, this is not a valid endpoint and results in a `DNSError` being thrown.

## Expected Behaviour
We currently special case one region less service `sdb`, I've made this into a list of strings and tacked in `route53` as well.

Now when you run the code example the request goes through successfully.

## Code Example
```julia
using AWSCore.Services: route53
route53("GET", "/2013-04-01/accountlimit/MAX_HEALTH_CHECKS_BY_OWNER")

# ERROR: DNSError: route53.us-east-1.amazonaws.com, unknown node or service (EAI_NONAME)
```

Co-authored-by: Matt Brzezinski <matt.brzezinski@invenia.ca>
@bors

This comment has been minimized.

Sign in to view
@mattBrzezinski

This comment has been minimized.

Sign in to view
bors bot added a commit that referenced this pull request Jan 28, 2020
@bors @mattBrzezinski
Merge #108
81c8971 
108: Set region to nothing for Route53 endpoint when making service URL r=mattBrzezinski a=mattBrzezinski

**Resolves:** #107 

## Current Behaviour
Currently when making a request to `route53` the URL which we hit is `route53.us-east-1.amazonaws.com`, this is not a valid endpoint and results in a `DNSError` being thrown.

## Expected Behaviour
We currently special case one region less service `sdb`, I've made this into a list of strings and tacked in `route53` as well.

Now when you run the code example the request goes through successfully.

## Code Example
```julia
using AWSCore.Services: route53
route53("GET", "/2013-04-01/accountlimit/MAX_HEALTH_CHECKS_BY_OWNER")

# ERROR: DNSError: route53.us-east-1.amazonaws.com, unknown node or service (EAI_NONAME)
```

Co-authored-by: Matt Brzezinski <matt.brzezinski@invenia.ca>
@bors

This comment has been minimized.

Sign in to view
@mattBrzezinski

This comment has been minimized.

Sign in to view
bors bot added a commit that referenced this pull request Jan 28, 2020
@bors
Try #108:
1d1d05e
@bors

This comment has been minimized.

Sign in to view
@mattBrzezinski

This comment has been minimized.

Sign in to view
bors bot added a commit that referenced this pull request Jan 28, 2020
@bors @mattBrzezinski
Merge #108
56e97a6 
108: Set region to nothing for Route53 endpoint when making service URL r=mattBrzezinski a=mattBrzezinski

**Resolves:** #107 

## Current Behaviour
Currently when making a request to `route53` the URL which we hit is `route53.us-east-1.amazonaws.com`, this is not a valid endpoint and results in a `DNSError` being thrown.

## Expected Behaviour
We currently special case one region less service `sdb`, I've made this into a list of strings and tacked in `route53` as well.

Now when you run the code example the request goes through successfully.

## Code Example
```julia
using AWSCore.Services: route53
route53("GET", "/2013-04-01/accountlimit/MAX_HEALTH_CHECKS_BY_OWNER")

# ERROR: DNSError: route53.us-east-1.amazonaws.com, unknown node or service (EAI_NONAME)
```

Co-authored-by: Matt Brzezinski <matt.brzezinski@invenia.ca>
@mattBrzezinski

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@mattBrzezinski

This comment has been minimized.

Sign in to view
bors bot added a commit that referenced this pull request Jan 28, 2020
@bors @mattBrzezinski
Merge #108
9cd1ec2 
108: Set region to nothing for Route53 endpoint when making service URL r=mattBrzezinski a=mattBrzezinski

**Resolves:** #107 

## Current Behaviour
Currently when making a request to `route53` the URL which we hit is `route53.us-east-1.amazonaws.com`, this is not a valid endpoint and results in a `DNSError` being thrown.

## Expected Behaviour
We currently special case one region less service `sdb`, I've made this into a list of strings and tacked in `route53` as well.

Now when you run the code example the request goes through successfully.

## Code Example
```julia
using AWSCore.Services: route53
route53("GET", "/2013-04-01/accountlimit/MAX_HEALTH_CHECKS_BY_OWNER")

# ERROR: DNSError: route53.us-east-1.amazonaws.com, unknown node or service (EAI_NONAME)
```

Co-authored-by: Matt Brzezinski <matt.brzezinski@invenia.ca>
@bors

This comment has been minimized.

Sign in to view
@mattBrzezinski
Copy link
Member Author

Failed because of AWSS3.jl.... fixed that lets try again.

@mattBrzezinski

This comment has been minimized.

Sign in to view
bors bot added a commit that referenced this pull request Jan 29, 2020
@bors @mattBrzezinski
Merge #108
114ad6f 
108: Set region to nothing for Route53 endpoint when making service URL r=mattBrzezinski a=mattBrzezinski

**Resolves:** #107 

## Current Behaviour
Currently when making a request to `route53` the URL which we hit is `route53.us-east-1.amazonaws.com`, this is not a valid endpoint and results in a `DNSError` being thrown.

## Expected Behaviour
We currently special case one region less service `sdb`, I've made this into a list of strings and tacked in `route53` as well.

Now when you run the code example the request goes through successfully.

## Code Example
```julia
using AWSCore.Services: route53
route53("GET", "/2013-04-01/accountlimit/MAX_HEALTH_CHECKS_BY_OWNER")

# ERROR: DNSError: route53.us-east-1.amazonaws.com, unknown node or service (EAI_NONAME)
```

Co-authored-by: Matt Brzezinski <matt.brzezinski@invenia.ca>
@bors

This comment has been minimized.

Sign in to view
@mattBrzezinski
Copy link
Member Author

Failed because the EC2 and ECS policies needed permissions....

@JuliaCloud JuliaCloud deleted a comment from bors bot Jan 29, 2020
@mattBrzezinski
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 29, 2020

Already running a review

@mattBrzezinski
Copy link
Member Author

bors cancel

@mattBrzezinski
Copy link
Member Author

bors ping

@bors
Copy link
Contributor

bors bot commented Jan 29, 2020

pong

@mattBrzezinski
Copy link
Member Author

bors try-

@mattBrzezinski
Copy link
Member Author

bors r-

@bors
Copy link
Contributor

bors bot commented Jan 29, 2020

Canceled

@mattBrzezinski
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Jan 29, 2020
@bors @mattBrzezinski
Merge #108
055f12e 
108: Set region to nothing for Route53 endpoint when making service URL r=mattBrzezinski a=mattBrzezinski

**Resolves:** #107 

## Current Behaviour
Currently when making a request to `route53` the URL which we hit is `route53.us-east-1.amazonaws.com`, this is not a valid endpoint and results in a `DNSError` being thrown.

## Expected Behaviour
We currently special case one region less service `sdb`, I've made this into a list of strings and tacked in `route53` as well.

Now when you run the code example the request goes through successfully.

## Code Example
```julia
using AWSCore.Services: route53
route53("GET", "/2013-04-01/accountlimit/MAX_HEALTH_CHECKS_BY_OWNER")

# ERROR: DNSError: route53.us-east-1.amazonaws.com, unknown node or service (EAI_NONAME)
```

Co-authored-by: Matt Brzezinski <matt.brzezinski@invenia.ca>
@mattBrzezinski
Copy link
Member Author

Talking to robots is fun....

@bors
Copy link
Contributor

bors bot commented Jan 29, 2020

Build failed

@mattBrzezinski
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jan 29, 2020
@bors
Try #108:
03dd4fe
@bors
Copy link
Contributor

bors bot commented Jan 29, 2020

try

Build failed

@mattBrzezinski
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Jan 29, 2020
@bors @mattBrzezinski
Merge #108
0da160a 
108: Set region to nothing for Route53 endpoint when making service URL r=mattBrzezinski a=mattBrzezinski

**Resolves:** #107 

## Current Behaviour
Currently when making a request to `route53` the URL which we hit is `route53.us-east-1.amazonaws.com`, this is not a valid endpoint and results in a `DNSError` being thrown.

## Expected Behaviour
We currently special case one region less service `sdb`, I've made this into a list of strings and tacked in `route53` as well.

Now when you run the code example the request goes through successfully.

## Code Example
```julia
using AWSCore.Services: route53
route53("GET", "/2013-04-01/accountlimit/MAX_HEALTH_CHECKS_BY_OWNER")

# ERROR: DNSError: route53.us-east-1.amazonaws.com, unknown node or service (EAI_NONAME)
```

Co-authored-by: Matt Brzezinski <matt.brzezinski@invenia.ca>
@bors
Copy link
Contributor

bors bot commented Jan 29, 2020

Build succeeded

@bors bors bot merged commit f6522e6 into master Jan 29, 2020
@bors bors bot deleted the MB/route53-fix branch January 29, 2020 03:21
@mattBrzezinski mattBrzezinski mentioned this pull request Jan 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omus omus omus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattBrzezinski @omus