feat: device authentication #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmaykm
reviewed
May 5, 2025
|
Since it's getting a little bit complicated now, with the package supporting multiple flows, could we add a small markdown file into
|
|
@mortenpi Added docs to the PR now. |
tanmaykm
reviewed
May 6, 2025
* refactor, use dex well known conf, use env for client id * Add docs for device flow * Move auth_suffix under states * tests for device auth * Use custom config endpoint
mortenpi
reviewed
May 23, 2025
Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com>
Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com>
Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com>
Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com>
Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com>
tanmaykm
approved these changes
May 26, 2025
| challenge::String | ||
| response::String | ||
| response::Union{String, Dict{String, Any}} |
There was a problem hiding this comment.
Feels like it would have been cleaner to bifurcate the state here to a separate RequestLoginDevice state. Then we wouldn't have to overload the same state and handling method with logic from both flows. But not going to insist a change in this PR.
| @@ -330,19 +441,22 @@ token, or to Failure if the polling times out, or there is an unexpected error. | |||
| """ | |||
| struct ClaimToken <: State | |||
| server::String | |||
| challenge::String | |||
| response::String | |||
| auth_suffix::String | |||
There was a problem hiding this comment.
Same here, a separate ClaimDeviceToken state may have been cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements device auth flow. As far as the state changes and interface is concerned, device auth flow is the same as the current browser challenge flow. The main advantage of device flow is that it avoids race conditions with the regular browser token because it is treated differently in the backend. Device token feature is not currently deployed on juliahub.com so this PR needs to be tested on development instances.
Working of this PR:
Please see the changes in auth-flow.md file.
Authenticating with device tokens:
The interface does not change for the user.
PkgAuthentication.authenticate()can be called and it will seamlessly decide on what authentication mechanism to use.