-
Notifications
You must be signed in to change notification settings - Fork 3
docs: document the current classic authentication flow #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Nishanth H. Kottary <nishanth@juliahub.com> Co-authored-by: Tanmay Mohapatra <tanmaykm@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great addition. We should add a section with details from #42.
It will be good to have the Pkg protocol documented. It is somewhat fragmented across multiple PRs now, which is hard to browse and can be sometimes confusing because of changes done over time. I had collated those into one rough consolidated doc sometime back... will put up a separate PR with that in a bit to iterate on and possibly add that as well. |
I think that should be a PR to Pkg.jl. It's a bit of out of scope for this package. In fairness, also some of the things from this PR should actually be documented there (the assumptions around |
Yes, makes sense. I'll make it to Pkg.jl... Update: JuliaLang/Pkg.jl#4234 |
Companion for #42, which attempts, in detail, to document the current ("classic") authentication flow. It's a non-standard flow, so currently the implementation here effectively is the specification of the flow (for anyone who would like to implement their own authenticated package server).
The device token docs from #42 could nicely be added to the end of the file.