Skip to content

Commit

Permalink
up DataAPI.jl to 1.7 and CategoricalArrays.jl to 0.10.0 (#2807)
Browse files Browse the repository at this point in the history
  • Loading branch information
bkamins authored Jun 28, 2021
1 parent 764540b commit d701c09
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 4 deletions.
4 changes: 2 additions & 2 deletions Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ Tables = "bd369af6-aec1-5ad0-b16a-f7cc5008161c"
Unicode = "4ec0a83e-493e-50e2-b9ac-8f72acf5a8f5"

[compat]
CategoricalArrays = "0.9.3"
CategoricalArrays = "0.10.0"
Compat = "3.17"
DataAPI = "1.6"
DataAPI = "1.7"
InvertedIndices = "1"
IteratorInterfaceExtensions = "0.1.1, 1"
Missings = "0.4.2, 1"
Expand Down
7 changes: 7 additions & 0 deletions src/DataFrames.jl
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@ import DataAPI,
DataAPI.Between,
DataAPI.Cols,
DataAPI.describe,
DataAPI.innerjoin,
DataAPI.outerjoin,
DataAPI.rightjoin,
DataAPI.leftjoin,
DataAPI.semijoin,
DataAPI.antijoin,
DataAPI.crossjoin,
Tables,
Tables.columnindex,
Future.copy!
Expand Down
4 changes: 3 additions & 1 deletion src/join/composer.jl
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
##
## Join / merge
##
## Implements methods for join functions defined in DataAPI.jl
##

# Like similar, but returns a array that can have missings and is initialized with missings
similar_missing(dv::AbstractArray{T}, dims::Union{Int, Tuple{Vararg{Int}}}) where {T} =
Expand Down Expand Up @@ -46,7 +48,7 @@ struct DataFrameJoiner
"Symbol or Pair{Symbol, Symbol}."))
end
end

if matchmissing === :notequal
if kind in (:left, :semi, :anti)
dfr = dropmissing(dfr, right_on, view=true)
Expand Down
2 changes: 1 addition & 1 deletion test/join.jl
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ end
@test levels(leftjoin(B, A, on=:b).b) == ["a", "b", "c"]
@test levels(rightjoin(A, B, on=:b).b) == ["a", "b", "c"]
@test levels(rightjoin(B, A, on=:b).b) == ["d", "c", "b", "a"]
@test levels(outerjoin(B, A, on=:b).b) == ["a", "b", "d", "c"]
@test levels(outerjoin(B, A, on=:b).b) == ["d", "a", "b", "c"]
@test levels(outerjoin(A, B, on=:b).b) == ["d", "c", "b", "a"]
@test levels(semijoin(A, B, on=:b).b) == ["d", "c", "b", "a"]
@test levels(semijoin(B, A, on=:b).b) == ["a", "b", "c"]
Expand Down

0 comments on commit d701c09

Please sign in to comment.