-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
up DataAPI.jl to 1.7 and CategoricalArrays.jl to 0.10.0 #2807
Conversation
@@ -355,8 +355,8 @@ end | |||
@test levels(leftjoin(A, B, on=:b).b) == ["d", "c", "b", "a"] | |||
@test levels(leftjoin(B, A, on=:b).b) == ["a", "b", "c"] | |||
@test levels(rightjoin(A, B, on=:b).b) == ["a", "b", "c"] | |||
@test levels(rightjoin(B, A, on=:b).b) == ["d", "c", "b", "a"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nalimilan - these changes follow CategoricalArrays.jl 0.10.0 release, so a check would be welcome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. Why aren't levels the same for inner and outer joins? ["d", "c", "b", "a"]
would sound like a good choice since levels(A.b)
is a superset of levels(B.b)
.
That said, since the old behavior wasn't ideal either, the new one is OK -- both are kind of arbitrary.
@@ -355,8 +355,8 @@ end | |||
@test levels(leftjoin(A, B, on=:b).b) == ["d", "c", "b", "a"] | |||
@test levels(leftjoin(B, A, on=:b).b) == ["a", "b", "c"] | |||
@test levels(rightjoin(A, B, on=:b).b) == ["a", "b", "c"] | |||
@test levels(rightjoin(B, A, on=:b).b) == ["d", "c", "b", "a"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. Why aren't levels the same for inner and outer joins? ["d", "c", "b", "a"]
would sound like a good choice since levels(A.b)
is a superset of levels(B.b)
.
That said, since the old behavior wasn't ideal either, the new one is OK -- both are kind of arbitrary.
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
The reason is (under CategoricalArrays.jl 0.10):
so as you can see the order of vectors matters (in this example in And in the
and as you can see the |
Ah right that's because the orders are not compatible, so we have to make a choice. |
Thank you! |
Fixes #2788