Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sublime-completions #12

Closed
wants to merge 1 commit into from
Closed

Added sublime-completions #12

wants to merge 1 commit into from

Conversation

phelipe
Copy link

@phelipe phelipe commented Aug 6, 2016

I Added auto completion to utf8 .

@ViktorQvarfordt
Copy link
Member

I like this! It deprecates the need for JuliaCompletions or JuliaUnicode.

One could argue that this should not be part of the language support package itself. That might be true for most languages, but the situation here is different. Unicode symbols are part of the language, the REPL has the exact same functionality and there is hight demand for this.

However, before this can be merged I have a few remarks and questions:

  • There are a lot of important unicode symbols missing, such as \otimes ⊗. Should we just merge the file https://github.com/jakeconnor/JuliaCompletions/blob/master/julia-utf.sublime-completions instead?
  • Do we really want completions for every function exported in Base? I.e. functions such as log and so on. This feels redundant, and also messy to maintain (for example sub is being deprecated in 0.5). How did you create this list?
  • Also, please keep the indentation nice and tidy (.sublime-completions is in JSON format, so 4 spaces indent etc.)

@ViktorQvarfordt
Copy link
Member

I did something similar in https://github.com/JuliaEditorSupport/Julia-sublime/blob/master/Julia.sublime-completions.

  • This uses the exact same completions as the REPL (so things like \otimes ⊗ are included).
  • I skipped completion for functions because I think this is more annoying than helpful.

@phelipe
Copy link
Author

phelipe commented Aug 11, 2016

Sorry for the delay in answering , I was busy with work . I used the table available in the documentation ( http://docs.julialang.org/en/release-0.4/manual/unicode-input/ ) to create the file and I removed some symbols because my sublime could not render some correctly. I think the font can be a problem with some symbols.

@ViktorQvarfordt
Copy link
Member

No problems, even though your code didn't get merged it was a good initiative. There are several issues with using a sublime-completions file (it messes up backslas colon triggers etc), and it is annoying to have all these completions pop up all the time. The package JuliaUnicode fixed this in a very nice way and this code is currently being merged into this package. See PR #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants