Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unicode autocomplete #20

Merged
merged 3 commits into from
Aug 12, 2016
Merged

unicode autocomplete #20

merged 3 commits into from
Aug 12, 2016

Conversation

randy3k
Copy link
Collaborator

@randy3k randy3k commented Aug 11, 2016

Added the unicode feature from JuliaUnicode.
(JuliaUnicode is also refactored as UnicodeCompletion.)

The code is not well-tested and has not been tested on Sublime Test 2.

BTW, any chance to add me to the JuliaEditorSupport team?

@ViktorQvarfordt
Copy link
Member

Great! Regarding the quality of the code, I've been using JuliaUnicode for a while and haven't run into any issues. If there are bugs we'll find them by using it. However, before we merge, it would be good to check that this doesn't break in sublime 2 (or at least breaks gracefully). (Is anyone at all using sublime 2 nowadays?)

I've added you as collaborator to this repo. If you want to be part of ther org JuliaEditorSupport I guess that can be fixed if needed as well. If you feel like making changes to the tmLanguage file, know that I'm rewriting it into a sublime-syntax file, which fixes a lot of issues, and brings new featurs. I'll push this into a dev branch later today. The tmLanguage will, however, remain for compatibility with older versions of sublime.

@randy3k
Copy link
Collaborator Author

randy3k commented Aug 11, 2016

It should be now ST2 compatible.

I guess we should also move to semitic versioning when it gets mature.

@ViktorQvarfordt
Copy link
Member

Looks good! Feel free to merge this when you're happy with it.

While we're discussing the tab completion. What do you think of the pop-up menu being shown directly on backslash, rather than on backslash + character? This is to allow for even faster completions. I realize that this would only be meaningful if the last inserted completion(s) are shown at the top in the popup on pressing backslash. What do you think? Would it be easy to implement?

And yes, we should definitely move to semver. I have some major changes to the syntax highlighting currently ongoing, I think that should be merged first, see #21.

@randy3k
Copy link
Collaborator Author

randy3k commented Aug 12, 2016

Showing the list directly on backslash can be acheived by specifying

    "auto_complete_triggers": [
        {
            "characters": "\\",
            "selector": "source.julia"
        }
    ],

in Julia.sublime-settings. However, I don't think there is a conical way to control the order of the completion list. But it does have some advantages. For example, typing \lpha will also show \alpha via fuzzy logic. In earlier code, it only shows options matching \a....

@randy3k randy3k merged commit 266fb0d into JuliaEditorSupport:master Aug 12, 2016
@randy3k randy3k deleted the unicode branch August 12, 2016 00:59
@ViktorQvarfordt
Copy link
Member

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants