-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unicode autocomplete #20
Conversation
Great! Regarding the quality of the code, I've been using JuliaUnicode for a while and haven't run into any issues. If there are bugs we'll find them by using it. However, before we merge, it would be good to check that this doesn't break in sublime 2 (or at least breaks gracefully). (Is anyone at all using sublime 2 nowadays?) I've added you as collaborator to this repo. If you want to be part of ther org JuliaEditorSupport I guess that can be fixed if needed as well. If you feel like making changes to the |
It should be now ST2 compatible. I guess we should also move to semitic versioning when it gets mature. |
Looks good! Feel free to merge this when you're happy with it. While we're discussing the tab completion. What do you think of the pop-up menu being shown directly on backslash, rather than on backslash + character? This is to allow for even faster completions. I realize that this would only be meaningful if the last inserted completion(s) are shown at the top in the popup on pressing backslash. What do you think? Would it be easy to implement? And yes, we should definitely move to semver. I have some major changes to the syntax highlighting currently ongoing, I think that should be merged first, see #21. |
Showing the list directly on backslash can be acheived by specifying "auto_complete_triggers": [
{
"characters": "\\",
"selector": "source.julia"
}
], in |
Awesome! |
Added the unicode feature from JuliaUnicode.
(JuliaUnicode is also refactored as UnicodeCompletion.)
The code is not well-tested and has not been tested on Sublime Test 2.
BTW, any chance to add me to the
JuliaEditorSupport
team?