-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename UnitQuaternion
to QuatRotation
#201
Conversation
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
=======================================
Coverage 86.74% 86.74%
=======================================
Files 14 14
Lines 1403 1403
=======================================
Hits 1217 1217
Misses 186 186
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
src/deprecated.jl
Outdated
# Deprecate Quat => UnitQuaternion | ||
Base.@deprecate_binding Quat UnitQuaternion true | ||
# Deprecate Quat => QuatRotation | ||
Base.@deprecate_binding Quat QuatRotation true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can probably remove this old deprecation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I remove RodriguesVec
and SPQuat
too?
The old deprecations for RodriguesVec
, SPQuat
and Quat
has been introduced in this commit (#116):
793d384#diff-0c3a3096ea8aa5548f7facdd7eaa649293a64f785376cca25e23f14d6af4301d
If we can remove the deprecation for Quat
, then I think the others also can be removed.
The old type names were already deprecated before v1.0.0
release, so I thought it's okay to remove them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, sounds fine.
See JuliaGeometry/Rotations.jl#201, from the latest Rotations.jl release https://github.com/JuliaGeometry/Rotations.jl/releases/tag/v1.1.0
See JuliaGeometry/Rotations.jl#201, from the latest Rotations.jl release https://github.com/JuliaGeometry/Rotations.jl/releases/tag/v1.1.0 (cherry picked from commit 0482ed2)
As discussed in #171 (comment),
UnitQuaternion
is confusing, and should be renamed toQuatRotation
.