Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Vector of colors and chars #69

Merged
merged 3 commits into from
Mar 23, 2022
Merged

Conversation

t-bltg
Copy link
Member

@t-bltg t-bltg commented Mar 22, 2022

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #69 (d140c77) into master (6f898ca) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   75.58%   75.74%   +0.16%     
==========================================
  Files           6        6              
  Lines         299      301       +2     
==========================================
+ Hits          226      228       +2     
  Misses         73       73              
Impacted Files Coverage Δ
src/rendering.jl 93.33% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f898ca...d140c77. Read the comment docs.

@t-bltg
Copy link
Member Author

t-bltg commented Mar 23, 2022

@SimonDanisch, would it be possible to review this PR, and merge / bump version if no objection ?

@SimonDanisch
Copy link
Member

Yes, on it!

@SimonDanisch SimonDanisch merged commit 9c6b7e2 into JuliaGraphics:master Mar 23, 2022
@t-bltg
Copy link
Member Author

t-bltg commented Mar 23, 2022

Awesome, thanks !

@t-bltg t-bltg deleted the cols branch March 23, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants