Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Plot as png #239

Merged
merged 4 commits into from
Mar 23, 2022
Merged

Save Plot as png #239

merged 4 commits into from
Mar 23, 2022

Conversation

t-bltg
Copy link
Member

@t-bltg t-bltg commented Mar 22, 2022

Allow saving plot as png file using FreeTypeAbstraction.

Needs #238 (true colors, RGB).
Needs JuliaGraphics/FreeTypeAbstraction.jl#69.

transparent
foo_tr

non-transparent
foo

@t-bltg t-bltg force-pushed the save_png branch 7 times, most recently from 37f09f7 to 1ed15f8 Compare March 22, 2022 14:49
@t-bltg t-bltg changed the title Save as png Save Plot as png Mar 22, 2022
@t-bltg t-bltg force-pushed the save_png branch 3 times, most recently from 126593f to d465829 Compare March 22, 2022 17:06
@johnnychen94
Copy link
Collaborator

This looks awesome! I assume this will eventually make the new DemoCards-based gallery work for UnicodePlots?

@t-bltg
Copy link
Member Author

t-bltg commented Mar 22, 2022

I assume this will eventually make the new DemoCards-based gallery work for UnicodePlots?

Haha, yes you found the hidden goal of this PR 🥇

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2022

Codecov Report

Merging #239 (e86be32) into master (ee91545) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head e86be32 differs from pull request most recent head 095bf2e. Consider uploading reports for the commit 095bf2e to get more accurate results

@@           Coverage Diff           @@
##           master     #239   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          28       28           
  Lines        1572     1638   +66     
=======================================
+ Hits         1571     1637   +66     
  Misses          1        1           
Impacted Files Coverage Δ
src/canvas.jl 100.00% <100.00%> (ø)
src/canvas/braillecanvas.jl 98.11% <100.00%> (ø)
src/canvas/densitycanvas.jl 100.00% <100.00%> (ø)
src/canvas/heatmapcanvas.jl 100.00% <100.00%> (ø)
src/canvas/lookupcanvas.jl 100.00% <100.00%> (ø)
src/common.jl 100.00% <100.00%> (ø)
src/graphics.jl 100.00% <100.00%> (ø)
src/graphics/bargraphics.jl 100.00% <100.00%> (ø)
src/graphics/boxgraphics.jl 100.00% <100.00%> (ø)
src/plot.jl 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee91545...095bf2e. Read the comment docs.

@t-bltg t-bltg force-pushed the save_png branch 2 times, most recently from 87fd6f6 to e86be32 Compare March 23, 2022 17:26
@t-bltg
Copy link
Member Author

t-bltg commented Mar 23, 2022

I'm sure there will be some polishing fixes needed, but I can save a layout in png from Plots.jl so I will test it now to build Plots docs.

@t-bltg t-bltg merged commit 64a5258 into JuliaPlots:master Mar 23, 2022
@t-bltg t-bltg deleted the save_png branch March 23, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants