-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework structure for 8bit
-> 24bit
mode
#238
Conversation
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 28 28
Lines 1501 1572 +71
=======================================
+ Hits 1500 1571 +71
Misses 1 1
Continue to review full report at Codecov.
|
2db58e3
to
b65cf5c
Compare
@johnnychen94, this PR is massive (due to the changes and addition of reference files), and I don't know if you have the time or the will to review it. If not, no worries, tell me so and I'll merge it later this week. |
Not really... Sorry.. I'm starting to put more time into my own work here to make my phd career not that a failure :sad: For the long-term goal that might never be achieved, I'm expecting to work closely with Term.jl, and eventually build a terminal-based IDE for Julia. This is why I was writing a decoder as well in JuliaImages/ImageInTerminal.jl#62. But I have to confess that I haven't looked into Term.jl at all. |
UInt32
instead ofUnion{Nothing,UInt8}
for canvas color (allows packingr
,g
,b
channels fortruecolor
or256
colors), blending rgb, ...Crayons
: reduces test files by about25%
24bit
and8bit
at runtime onCOLORTERM
env variable (generic) orUP_COLORMODE
UnicodePlots
as apng
image (SavePlot
aspng
#239)printstyled
inBase
and delegate colors toCrayons
(more flexible for style change (e.g.bold
,italic
, ...))24bit
mode forheatmap
s or when using colorbars:USE_LUT
is set tofalse
by default, hence using256
colors when using named colors or integers in24bit
mode.perf regression
pr
master
visual inspection