Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework structure for 8bit -> 24bit mode #202

Closed
wants to merge 6 commits into from

Conversation

t-bltg
Copy link
Member

@t-bltg t-bltg commented Jan 16, 2022

  • use UInt32 instead of UInt8 for canvas color (allows packing r, g, b channels for truecolor support), blending rgb, ...

  • use more Crayons objects, reduces test files by about 25%

  • toggle between 24bit and 8bit at runtime

  • benchmark for any regressions

@t-bltg t-bltg marked this pull request as draft January 16, 2022 23:56
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2022

Codecov Report

Merging #202 (bb0676e) into master (65b9368) will decrease coverage by 1.55%.
The diff coverage is 86.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
- Coverage   99.82%   98.27%   -1.56%     
==========================================
  Files          23       23              
  Lines        1164     1218      +54     
==========================================
+ Hits         1162     1197      +35     
- Misses          2       21      +19     
Impacted Files Coverage Δ
src/graphics/boxgraphics.jl 100.00% <ø> (ø)
src/interface/heatmap.jl 100.00% <ø> (ø)
src/common.jl 86.89% <73.61%> (-13.11%) ⬇️
src/canvas/asciicanvas.jl 100.00% <100.00%> (ø)
src/canvas/blockcanvas.jl 100.00% <100.00%> (ø)
src/canvas/braillecanvas.jl 98.07% <100.00%> (ø)
src/canvas/densitycanvas.jl 100.00% <100.00%> (ø)
src/canvas/dotcanvas.jl 100.00% <100.00%> (ø)
src/canvas/heatmapcanvas.jl 98.24% <100.00%> (-0.04%) ⬇️
src/canvas/lookupcanvas.jl 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65b9368...bb0676e. Read the comment docs.

@t-bltg
Copy link
Member Author

t-bltg commented Mar 20, 2022

Superseded by #238.

@t-bltg t-bltg closed this Mar 20, 2022
@t-bltg t-bltg deleted the 24bit branch June 20, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants