Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework colormaps, prepare contourplot #203

Merged
merged 5 commits into from
Jan 17, 2022
Merged

Conversation

t-bltg
Copy link
Member

@t-bltg t-bltg commented Jan 17, 2022

  • Add more colormaps (8bit): rationale for this: enhanced colormap range using 8bit colors instead of arbitrary 24bit rgb, new reference files cover these. These new colormaps also prepare the change initiated at Rework structure for 8bit -> 24bit mode #202 for truecolor 24bit support.
  • Change existing colormap data structure to use Vector{NTuple} instead of Vector{Vector}, enforce const.
  • Move colorbar computations from heatmap to canvas in order to prepare contourplot integration, and fix [FR] stand-alone version of printcolorbarrow to draw a colorbar in isolation #169.
  • Move colormap callback computation to colormaps.jl, added tests are covering this.

src/canvas.jl Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2022

Codecov Report

Merging #203 (3b63f74) into master (5beb0b6) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
- Coverage   99.65%   99.65%   -0.01%     
==========================================
  Files          23       23              
  Lines        1171     1166       -5     
==========================================
- Hits         1167     1162       -5     
  Misses          4        4              
Impacted Files Coverage Δ
src/canvas/heatmapcanvas.jl 96.15% <ø> (-2.13%) ⬇️
src/colormaps.jl 100.00% <ø> (ø)
src/canvas.jl 100.00% <100.00%> (ø)
src/interface/heatmap.jl 100.00% <100.00%> (ø)
src/plot.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5beb0b6...3b63f74. Read the comment docs.

@t-bltg t-bltg requested a review from johnnychen94 January 17, 2022 11:02
Copy link
Collaborator

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good... One small suggestion and one question.

src/colormaps.jl Outdated Show resolved Hide resolved
src/plot.jl Show resolved Hide resolved
@t-bltg t-bltg mentioned this pull request Jan 17, 2022
@t-bltg t-bltg force-pushed the colormaps branch 8 times, most recently from 5b0451f to 3d78940 Compare January 17, 2022 16:32
@t-bltg
Copy link
Member Author

t-bltg commented Jan 17, 2022

CI is finally looking green.

@t-bltg t-bltg requested a review from johnnychen94 January 17, 2022 16:51
@t-bltg t-bltg merged commit d81561f into JuliaPlots:master Jan 17, 2022
@t-bltg t-bltg deleted the colormaps branch June 20, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] stand-alone version of printcolorbarrow to draw a colorbar in isolation
3 participants