-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework colormaps, prepare contourplot
#203
Conversation
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
==========================================
- Coverage 99.65% 99.65% -0.01%
==========================================
Files 23 23
Lines 1171 1166 -5
==========================================
- Hits 1167 1162 -5
Misses 4 4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good... One small suggestion and one question.
5b0451f
to
3d78940
Compare
CI is finally looking green. |
8bit
colors instead of arbitrary24bit
rgb, new reference files cover these. These new colormaps also prepare the change initiated at Rework structure for8bit
->24bit
mode #202 for truecolor24bit
support.Vector{NTuple}
instead ofVector{Vector}
, enforceconst
.heatmap
tocanvas
in order to preparecontourplot
integration, and fix [FR] stand-alone version ofprintcolorbarrow
to draw a colorbar in isolation #169.callback
computation tocolormaps.jl
, added tests are covering this.