Updates to github-action-benchmark index.html #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nah I trust you :). Funny that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the default index.html provided by github-action-benchmark to more closely match Lux.jl's benchmark display. I also added an option at the top to view memory use and allocation, in addition to time, and deleted the /bench folder which was used to store the results for one commit before we changed the folder name to 'benchmark'.
If you want to test these changes, I've been using the VSCode live server extension: just make sure the data.js and index.html pages are in the same directory, and with the index.html file open, right click -> Open with Live Server. Feel free to change the colors or any other display details.