Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSOC: Add GPU Explanation Section to Documentation #470

Merged
merged 12 commits into from
Aug 27, 2024

Conversation

rkierulf
Copy link
Collaborator

@rkierulf rkierulf commented Aug 23, 2024

@rkierulf rkierulf added the documentation Improvements to docs., it also triggers doc preview label Aug 23, 2024
@rkierulf rkierulf changed the title Add GPU Explanation Section to Documentation GSOC: Add GPU Explanation Section to Documentation Aug 23, 2024
Copy link
Member

@cncastillo cncastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I think a few more details could be included to make the implementation easier to understand

docs/src/explanation/4-gpu-explanation.md Show resolved Hide resolved
docs/src/explanation/4-gpu-explanation.md Show resolved Hide resolved
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.93%. Comparing base (e805677) to head (d3268f2).
Report is 13 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #470   +/-   ##
=======================================
  Coverage   90.93%   90.93%           
=======================================
  Files          53       53           
  Lines        2934     2934           
=======================================
  Hits         2668     2668           
  Misses        266      266           
Flag Coverage Δ
base 88.20% <ø> (ø)
core 92.61% <ø> (ø)
files 93.55% <ø> (ø)
komamri 93.98% <ø> (ø)
plots 89.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@cncastillo cncastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!!! 🥳🥳🎊

@cncastillo
Copy link
Member

cncastillo commented Aug 23, 2024

Oh sorry, could you add the "using CUDA" to getting started and the readme and point to this section? As now it is needed for the GPU acceleration.

@rkierulf
Copy link
Collaborator Author

Yep, no problem! I think I got the URL correct for linking to the new section but I'll need to check once the documentation is built

@rkierulf
Copy link
Collaborator Author

Hmm, it looks like the URL still isn't appearing as a link. It might be ok once it gets merged into the main branch. Thoughts @cncastillo ?

@cncastillo
Copy link
Member

Yeah, it makes sense. Let's put the URL for the readme later, in the docs I think you can do relative urls

Copy link
Member

@cncastillo cncastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the link was not using the correct syntax (comment)[linkurl] instead of [comment](linkurl).

docs/src/how-to/1-getting-started.md Outdated Show resolved Hide resolved
@cncastillo cncastillo merged commit e86f5d6 into master Aug 27, 2024
19 checks passed
@cncastillo cncastillo deleted the GSOC-documentation branch August 27, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements to docs., it also triggers doc preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants