Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Libdl dependency issue. #26

Merged
merged 2 commits into from
Aug 9, 2018
Merged

Fix Libdl dependency issue. #26

merged 2 commits into from
Aug 9, 2018

Conversation

fredrikekre
Copy link
Contributor

No description provided.

@fredrikekre
Copy link
Contributor Author

Hmm https://github.com/fredrikekre/CodecZlib.jl/blob/0d59c95781b972aefd834ed4f413cab9ce208126/src/CodecZlib.jl#L38 is already in there...

@bicycle1885
Copy link
Member

What issue does this solve? Why this is better than using Compad.Libdl is not clear to me...

@KristofferC
Copy link
Member

The problem is:

  1. Stdlibs need to be declared as dependencies to load on 0.7+
  2. Stdlibs cannot be in REQUIRE files
  3. The new registry is converted from METADATA for the time being
  4. To deal with 1), the source code is parsed for using Stdlib statements and those are added to the deps in the new registry
  5. BinaryProvider injects a using Libdl into packages.
  6. So this package needs a Libdl in the dependencies. This PR fixes that.

@bicycle1885 bicycle1885 merged commit 074fada into JuliaIO:master Aug 9, 2018
@bicycle1885
Copy link
Member

I see. I think using Compat.Stdlib should be parsed as well but I'm not sure. Anyway, thank you for the pull request and explanation.

@fredrikekre fredrikekre deleted the patch-1 branch August 9, 2018 11:18
@bicycle1885 bicycle1885 mentioned this pull request Aug 9, 2018
Closed
@juan-pablo-vielma juan-pablo-vielma mentioned this pull request Dec 31, 2018
Merged
@visr visr mentioned this pull request Jan 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fredrikekre @bicycle1885 @KristofferC