Multi-GCC BinaryBuilder Binary Dependencies for Julia v1.0 #48
Conversation
fix gcc4 bug in Windows
catch up with master
| @@ -6,6 +6,7 @@ VERSION < v"0.7.0-beta2.199" && __precompile__() | |||
| module Clp | |||
|
|
|||
| using Compat | |||
| using Libdl | |||
There was a problem hiding this comment.
Tu suppress a warning about Clp not having Libdl in its dependencies (Libdl is used by BinaryProvider), e.g. : JuliaIO/CodecZlib.jl#26
| ) | ||
|
|
||
| # To fix gcc4 bug in Windows |
There was a problem hiding this comment.
There should also be a link to the issue here.
deps/build.jl
Outdated
| # trying to install is not itself installed) then load it up! | ||
| if unsatisfied || !isinstalled(dl_info...; prefix=prefix) | ||
| # Download and install binaries | ||
| # no dynamic dependencies until Pkg3 support for binaries |
There was a problem hiding this comment.
Inconsistent indent level of the comments. Usually comments start at the indent level of the surrounding code, e.g.,
if foo
f()
# This is a comment.
end
|
@juan-pablo-vielma note that I pushed changes to your branch, so you'll need to pull from your own branch before making additional commits. |
|
Just tested the PR on ArchLinux and it works |
deps/build.jl
Outdated
| LibraryProduct(prefix, String["libOsiClp"], :libOsiClp), | ||
| LibraryProduct(prefix, String["libClp"], :libClp), | ||
| LibraryProduct(prefix, String["libClpSolver"], :libClpSolver), | ||
| #LibraryProduct(prefix, ["libOsiClp"], :libOsiClp), |
There was a problem hiding this comment.
Style nit: Remove commented code or explain why it's commented and when it should be uncomented.
There was a problem hiding this comment.
deleted. We may want it back on the BinaryBuilder side eventually, but not on the BinaryProvider side.
Provides binaries with new multi-gcc BinaryProvider that should work with official julia binaries and custom source-builds. In particular, it should fix #38 and jump-dev/Cbc.jl#56
To avoid future issues like jump-dev/Cbc.jl#56 (and jump-dev/SCS.jl#107 (comment)) the binaries are self contained:
using the separate dynamic libraries for dependencies would not provide an advantage until there is Pkg3 support for binary dependencies (right now each COIN solver would download its own copy of each dependency, which could cause unexpected symbol clashes if the solvers are independently updated).