-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add public
declarations using eval
#175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, provided someone familiar with the Tar API confirms that all documented behavior of create, extract, list, rewrite, tree_hash, and Header is part of the public API.
Those are the 6 things that are currently documented in the Tar.jl manual, so I think it's safe to say that they are public APIs. |
I just updated this to contain the merge commit of #173 to make sure to not accidentally break something. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #175 +/- ##
=======================================
Coverage 97.53% 97.53%
=======================================
Files 4 4
Lines 810 810
=======================================
Hits 790 790
Misses 20 20 ☔ View full report in Codecov by Sentry. |
@stevengj, I think this is ready to merge. |
Resolves the
Tar.jl
part of JuliaLang/julia#51335 as suggested in #173 (comment).Alternative to and thus closes #174.
This might have semantical conflicts with #173, so please re-run CI after merge of #173.cc @LilithHafner @stevengj