-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly mark all symbols as public
or not
#51335
Comments
is this issue solved or can i help? |
This issue is very much not solved, and we would appreciate your help! Any symbol that is mentioned in the manual in Julia 1.9 or 1.10 and is not exported should be marked as public with |
Can you explain me bit more specifically about how should i approach this. |
You could install Julia 1.11 (download the nightly or build from source) and then run |
so should i download all the dependencies for building julia or can i just clone it in my local machine and run for this task |
Ideally, this should work:
If you try this and get an error and you are running on a mainstream OS, let us know, because that's probably a bug on our end. |
make doesnt work for windows |
Ah, right. Windows. The steps for building from source are a bit more complicated: https://docs.julialang.org/en/v1/devdocs/build/windows/#Source-distribution You don't have to build from source to contribute, but it can be very helpful in testing your PRs. |
|
How is this possible lol julia> Base.include === include
false |
Every module has an |
julia> Base.MainInclude.include === include === Main.include
true |
What about Stdlibs? Take docs HTML: https://docs.julialang.org/en/v1/stdlib/SHA/ Do we need to change |
No need to do that, AFAIK: either one of |
Hello, Is this issue solved, else I'd love to contribute. It is my first time contributing to open source, so any tips on how to go about it would help a ton. Thanks |
For the |
I'm looking at candidates in |
Xref #53900 for For |
OK, the PR for |
I don't think this has to be on the milestone since adding a |
It's just that users will start getting "this symbol may be internal" warnings for docstrings of nonpublic symbols in 1.11 |
I'm not a fan of this, because that means a symbol could be public on 1.10 (because it's in the manual), private on 1.11 (because it's not declared with In fact, making a public symbol private is a breaking change according to SemVer, so this issue should block release of 1.11. |
There are some modules that are declared public
# Modules
Checked,
Filesystem,
Order,
Sort, I think the |
Iterators is already public by way of export julia> Iterators
Base.Iterators
julia> Base.ispublic(Base, :Iterators)
true
julia> VERSION
v"1.11.0-beta1"
Either that module should be public or Base should re-publicize its exports. I prefer the former, slightly. |
Ah, I see, thanks.
Yeah, I think the |
|
#50105 added a preliminary list of symbols to be marked as
public
fromBase
. We should finalize that list for Base, stdlibs, and submodules before 1.11.Tasks
The text was updated successfully, but these errors were encountered: