-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous improvements #324
Conversation
JuliaPackaging/BinaryBuilderBase.jl#166 has removed support for freebsd 11 and switched to freebsd 12.
* all `gensym` calls are recorded. * Fix JuliaInterop#325.
It turns out that it is very easy to split common file and API file and topo-sort the macros. This makes resurrecting old scripts much easier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As for #325, I think it can be fixed by merely caching those inner nested tag types. The line needed to be fixed is
Clang.jl/src/generator/resolve_deps.jl
Lines 154 to 156 in 50670a8
elseif occursin("anonymous", spelling(ty)) | |
# it could be a nested anonymous tag-type. | |
# pass |
@@ -110,6 +110,7 @@ function pretty_print(io, node::ExprNode{<:AbstractStructNodeType}, options::Dic | |||
inline = struct_field_comment_style == "inline" | |||
struct_def = node.exprs[1] | |||
mutable, name, members = struct_def.args | |||
name = Base.sym_to_string(name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Escape struct names with var""
examples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with use_deterministic_symbol
set to false,
struct S {
struct {
int a;
} b;
};
output would have been
mutable struct ##Ctag#499
a::Cint
var"##Ctag#499"() = new()
end
Because |
Thanks! I now see that they are compared by actual declaration locations. |
The ultimate solution would be to directly work with Clang's |
Is this ready for review? better to split this to individual PRs. |
Yes this is ready, this branch was meant to hold commits that might depend on each other, which now seems not happening a lot. I will split them into individual PRs soon. |
All of the commits are moved to other branches. Closed. |
Fix #320, fix #325, fix #326.