Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PlatformSupport and GCCBootstrap artifacts for FreeBSD 12 #166

Merged
merged 8 commits into from
Aug 11, 2021
Merged

Add PlatformSupport and GCCBootstrap artifacts for FreeBSD 12 #166

merged 8 commits into from
Aug 11, 2021

Conversation

ararslan
Copy link
Member

@ararslan ararslan commented Aug 10, 2021 •
edited
Loading

@ararslan
Copy link
Member Author

Actually, I think I need to delete the ones for FreeBSD 11, since CI seems to be picking those up. Not sure whether that's related to the failure in the privileged runner tests though.

@ararslan
Copy link
Member Author

ararslan commented Aug 10, 2021 •
edited
Loading

Ah, it can't find PlatformSupport because https://github.com/JuliaPackaging/BinaryBuilderBase.jl/blob/master/src/Rootfs.jl#L512 is telling it to look specifically for v"2021.1.28" but for FreeBSD 12 we only have v"2021.8.9". Nothing else has that version though. Was I supposed to rebuild PlatformSupport for everything?

@giordano
Copy link
Member

Was I supposed to rebuild PlatformSupport for everything?

Oh, yes, it makes sense 😄

giordano
giordano reviewed Aug 10, 2021
View reviewed changes
Artifacts.toml Outdated Show resolved Hide resolved
giordano
giordano approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tests are passing here and for BinaryBuilder (only failures are known unrelated Rust issues). @staticfloat any comments?

@ararslan ararslan merged commit 46437be into master Aug 11, 2021
@ararslan ararslan deleted the aa/freebsd12.2 branch August 11, 2021 15:47
@ararslan ararslan mentioned this pull request Aug 11, 2021
Merged
melonedo added a commit to melonedo/Clang.jl that referenced this pull request Aug 24, 2021
@melonedo
Update freebsd version
8669305 
JuliaPackaging/BinaryBuilderBase.jl#166 has removed support for freebsd 11 and switched to freebsd 12.
@melonedo melonedo mentioned this pull request Aug 27, 2021
Closed
5 tasks
melonedo added a commit to melonedo/Clang.jl that referenced this pull request Sep 9, 2021
@melonedo
Update freebsd version
6085c7e 
JuliaPackaging/BinaryBuilderBase.jl#166 has removed support for freebsd 11 and switched to freebsd 12.
@melonedo melonedo mentioned this pull request Sep 9, 2021
Merged
@giordano giordano mentioned this pull request Nov 24, 2021
Merged
This was referenced Jun 9, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano approved these changes

@staticfloat staticfloat staticfloat approved these changes

Assignees
No one assigned
Labels
freebsd 😈 toolchain 🔧 ⛓️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ararslan @giordano @staticfloat