Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Artifacts.toml for FreeBSD 13.2 #312

Merged
merged 3 commits into from
Jun 26, 2023
Merged

Update Artifacts.toml for FreeBSD 13.2 #312

merged 3 commits into from
Jun 26, 2023

Conversation

ararslan
Copy link
Member

@ararslan ararslan commented Jun 11, 2023

#166 for the modern era. Changes to Artifacts.toml generated with JuliaPackaging/Yggdrasil#6865.

To do:

  • PlatformSupport
  • GCCBootstrap@4
  • GCCBootstrap@5
  • GCCBootstrap@6
  • GCCBootstrap@7
  • GCCBootstrap@8
  • GCCBootstrap@9
  • GCCBootstrap@10
  • GCCBootstrap@11
  • GCCBootstrap@12
  • Determine whether the 12.2 artifacts should be removed from the file as was done when going from 11 to 12
  • Bump version

@ararslan
Copy link
Member Author

Unable to automatically install 'GCCBootstrap-x86_64-linux-gnu.v5.2.0.x86_64-linux-musl.unpacked' from '/home/runner/work/BinaryBuilderBase.jl/BinaryBuilderBase.jl/Artifacts.toml'

...but why

@giordano
Copy link
Member

I don't know, we've been seeing that in the last few days but I haven't had the time to look at the problem

@ararslan
Copy link
Member Author

Does that block merging? Is there anything aside from CI on this PR that should be checked before it can be merged?

@giordano
Copy link
Member

Does that block merging?

No

Is there anything aside from CI on this PR that should be checked before it can be merged?

I honestly don't remember exactly what we need to do else when adding/changing a platform, tests are passing (apart from the unrelated failure), but don't remember if we test all platforms. I haven't had to have a look at this PR in general

@ararslan
Copy link
Member Author

It's still a draft, I just wanted to make sure I cover all of the steps needed.

@ararslan ararslan marked this pull request as ready for review June 23, 2023 18:47
@ararslan ararslan requested review from staticfloat and giordano June 23, 2023 18:47
@ararslan ararslan merged commit 7a6e189 into master Jun 26, 2023
@ararslan ararslan deleted the aa/freebsd13 branch June 26, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants