-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add uuid5 #685
Add uuid5 #685
Conversation
This makes |
Thanks for catching it. It was an overlook. |
Hmm, JuliaLang/julia#28761 neither exports nor documents those constants. Are they actually part of the API and guaranteed to stay for 1.x? Otherwise I'd prefer not to have a Compat for them. How much are these needed anyway? |
I removed |
Thanks. Better to be conservative here than to provide functionality that could happen to be removed from Julia... |
Modulo a slightly more descriptive entry in the README this looks good to me. If want, you can include a version bump in |
Co-Authored-By: Martin Holters <martin.holters@hsu-hh.de>
Thanks for the review. I updated the version number. |
Thanks! |
This PR adds
uuid5
from JuliaLang/julia#28761