Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uuid5 #685

Merged
merged 7 commits into from
Feb 6, 2020
Merged

Add uuid5 #685

merged 7 commits into from
Feb 6, 2020

Conversation

tkf
Copy link
Member

@tkf tkf commented Feb 1, 2020

This PR adds uuid5 from JuliaLang/julia#28761

@martinholters
Copy link
Member

This makes Compat,namespace_dns, Compat,namespace_url, Compat,namespace_oid, and Compat,namespace_x500 available but doesn't mention them in the README. Providing functionality but not telling anyone seems inconsistent to me. What's the reason for this?

@tkf
Copy link
Member Author

tkf commented Feb 3, 2020

Thanks for catching it. It was an overlook.

@martinholters
Copy link
Member

Hmm, JuliaLang/julia#28761 neither exports nor documents those constants. Are they actually part of the API and guaranteed to stay for 1.x? Otherwise I'd prefer not to have a Compat for them. How much are these needed anyway?

@tkf
Copy link
Member Author

tkf commented Feb 4, 2020

I removed namespace_(dns|oid|url|x500) from src/Compat.jl. I suppose whoever wants them has to first document them in the UUIDs stdlib as stable API.

@martinholters
Copy link
Member

Thanks. Better to be conservative here than to provide functionality that could happen to be removed from Julia...

README.md Outdated Show resolved Hide resolved
@martinholters
Copy link
Member

Modulo a slightly more descriptive entry in the README this looks good to me. If want, you can include a version bump in Project.toml and we make a release immediately after merging.

tkf and others added 2 commits February 5, 2020 13:07
Co-Authored-By: Martin Holters <martin.holters@hsu-hh.de>
@tkf
Copy link
Member Author

tkf commented Feb 5, 2020

Thanks for the review. I updated the version number.

@martinholters martinholters merged commit 2121e6b into JuliaLang:master Feb 6, 2020
@martinholters
Copy link
Member

Thanks!

@tkf tkf deleted the uuid5 branch February 7, 2020 02:32
@tkf tkf restored the uuid5 branch February 8, 2020 08:29
@tkf tkf deleted the uuid5 branch February 8, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants