update to use JuliaSyntax.jl v1.0.0 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inkydragon
force-pushed
the
JuliaSyntax-v1.0
branch
from
051b17d to
cdd5803
Compare
3 tasks
|
Brilliant, thanks for doing this work Chengyu! |
- `length(node.args)` => `numchildren(node)`
- `node\.args\[(\d*)\]` => `node[$1]` - `.args[` => `[`
- `node.args` => `children(node)`
- `node.span` => `span(node)`
inkydragon
force-pushed
the
JuliaSyntax-v1.0
branch
from
cdd5803 to
1982514
Compare
inkydragon
force-pushed
the
JuliaSyntax-v1.0
branch
from
1f35511 to
2680c8b
Compare
|
I think this pr is ready for review. But not sure when to merge it. One idea is to keep this pr open, and
Otherwise this pr will not pass CI. (Update) |
inkydragon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr should be merged with the PR that updates the JuliaSyntax.jl version.
The tests here are currently invalid (because JuliaSyntax.jl has not been upgraded yet)
JuliaSyntax.jl Breaking changes: