-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update JuliaSyntax to v1.0.0 #57188
base: master
Are you sure you want to change the base?
Conversation
@@ -1,4 +1,4 @@ | |||
JULIASYNTAXHIGHLIGHTING_BRANCH = main | |||
JULIASYNTAXHIGHLIGHTING_SHA1 = 19bd57b89c648592155156049addf67e0638eab1 | |||
JULIASYNTAXHIGHLIGHTING_SHA1 = cdd5803653a0fee6952f4b48e62f07e9381d8676 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current commit only exists in my PR for JuliaSyntaxHighlighting.jl.
(JuliaLang/JuliaSyntaxHighlighting.jl#9)
So do not merge
.
8ccddea
to
54e1520
Compare
@test Meta.lower(Main, :(a.[1])) == Expr(:error, "invalid syntax \"a.[1]\"") | ||
@test Meta.lower(Main, :(a.{1})) == Expr(:error, "invalid syntax \"a.{1}\"") | ||
@test_broken Meta.lower(Main, :(a.[1])) == Expr(:error, "invalid syntax \"a.[1]\"") | ||
@test_broken Meta.lower(Main, :(a.{1})) == Expr(:error, "invalid syntax \"a.{1}\"") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems a regression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe good with an issue at JuliaSyntax.jl so there is something tracking this.
54e1520
to
58a2047
Compare
Not sure if this is a bug or just need to update the test case.
Lines 2456 to 2459 in f209eba
Test case add in #37534 Seems there is something wrong with macro m1()
quote
((x...,)) -> (x)
end |> esc
end
macro m2()
quote
(x...) -> (x)
end |> esc
end Those two fixes work for me. |
58a2047
to
601e395
Compare
This pr:
Note:
JuliaSyntax.jl
contains some breaking changes in v1.0.0,so we need to update
JuliaSyntaxHighlighting.jl
at the same time.Close #57166