Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test deps not required on nightly #1144

Closed
fredrikekre opened this issue Apr 12, 2019 · 7 comments
Closed

Test deps not required on nightly #1144

fredrikekre opened this issue Apr 12, 2019 · 7 comments
Assignees
Milestone

Comments

@fredrikekre
Copy link
Member

e.g. https://travis-ci.org/JuliaGraphs/LightGraphs.jl/builds/519328333

@fredrikekre fredrikekre added this to the 1.2 milestone Apr 12, 2019
@KristofferC
Copy link
Member

I'm guessing the LOAD_PATH is no longer correctly set on the spawned process?

@fredrikekre
Copy link
Member Author

@00vareladavid
Copy link
Contributor

Can you elaborate on the issue? The original isolation is not working anymore?

@fredrikekre
Copy link
Member Author

Probably caused by #1058 which we backported to 1.0.4 and 1.1.1 so not this bug is there too 🎉

@fredrikekre
Copy link
Member Author

@KristofferC
Copy link
Member

KristofferC commented Jun 8, 2019

I think what happens is that recursive dependencies gets put into the temporary project file but those should only be put into the manifest file.

So if Test somehow ends up as a recursive dependency on the package tested, this will happen.

@fredrikekre
Copy link
Member Author

Yea, I was trying to fix that, but I think the reason we add them to the project is that the resolver can only keep project-deps fixed on a version. I tried just pinning them in the manifest, but seems like it is beeing ignored.

bors bot added a commit that referenced this issue Jun 9, 2019
1222: Don't put recursive dependencies in the test/build project, fixes #1144. r=fredrikekre a=fredrikekre



Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
bors bot added a commit that referenced this issue Jun 9, 2019
1222: Don't put recursive dependencies in the test/build project, fixes #1144. r=KristofferC a=fredrikekre



Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
@bors bors bot closed this as completed in 70e55d0 Jun 9, 2019
fredrikekre added a commit that referenced this issue Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants