Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: ASE v0.4.0 #1265

Merged
merged 1 commit into from
Jun 8, 2019
Merged

New version: ASE v0.4.0 #1265

merged 1 commit into from
Jun 8, 2019

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Jun 7, 2019

A/ASE/Compat.toml Outdated Show resolved Hide resolved
@cortner
Copy link
Contributor

cortner commented Jun 7, 2019

thanks for catching this. Ok now?

@fredrikekre
Copy link
Member

Hi, no, you need to list all breaking versions, e.g.

[compat]
julia = "0.7, 1"

is what most packages use.

@cortner
Copy link
Contributor

cortner commented Jun 7, 2019

Should this be ok?

[compat]
julia = "0.7, 1"
JuLIP = "≧ 0.6.0"
NeighbourLists = "≧ 0.3.0"
PyCall = "≧ 1.90.0"

@cortner
Copy link
Contributor

cortner commented Jun 7, 2019

I'm getting

Error while trying to register: Unexpected error in registration

@cortner
Copy link
Contributor

cortner commented Jun 7, 2019

Thought I suppose, this is more sensible:

[compat]
julia = "0.7, 1"
JuLIP = "^0.6.0"
NeighbourLists = "^0.3.0"
PyCall = "^1.90.0"

@fredrikekre
Copy link
Member

fredrikekre commented Jun 7, 2019

You need instead of .

Edit: JuliaRegistries/Registrator.jl#176

UUID: 51974c44-a7ed-5088-b8be-3e78c8ba416c
Repo: https://github.com/libAtoms/ASE.jl.git
Tree: 51dc86fa0e4d53f4de5b2e367c79175939980c6f

Registrator tree SHA: 8ad2ec9f6b6b8b9975d371ec3f65c87ee84ddb49
@fredrikekre
Copy link
Member

I just note that you currently rely on a Pkg bug (JuliaLang/Pkg.jl#1144) where you don't need to include test-dependencies in the project file. You can see that it fails CI in 0.7 where this bug does not exist. You should look into adding Test as a test-dependency.

@fredrikekre fredrikekre merged commit af8761a into master Jun 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the register/ASE/v0.4.0 branch June 8, 2019 09:34
@julia-tagbot
Copy link

julia-tagbot bot commented Jun 8, 2019

I've created release v0.4.0, here it is.

@cortner
Copy link
Contributor

cortner commented Jun 8, 2019

Many thanks- I’ll have that in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants