Skip to content

Commit

Permalink
@inbounds annotations for filter (#30156)
Browse files Browse the repository at this point in the history
  • Loading branch information
@andyferris
andyferris authored Dec 11, 2018
1 parent 73c8eb4 commit 58f9bf7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion base/array.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2333,7 +2333,7 @@ function filter!(f, a::AbstractVector)

for acurr in a
if f(acurr)
a[i] = acurr
@inbounds a[i] = acurr
y = iterate(idx, state)
y === nothing && (i += 1; break)
i, state = y
Expand Down

2 comments on commit 58f9bf7

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

Please sign in to comment.