@inbounds annotations for filter
#30156
Conversation
|
Is travis MacOS build busted for everyone? |
| @@ -2345,7 +2345,7 @@ function filter!(f, a::AbstractVector) | |||
|
|
|||
| for acurr in a | |||
| if f(acurr) | |||
| a[i] = acurr | |||
| @inbounds a[i] = acurr | |||
There was a problem hiding this comment.
Is there a policy for @inbounds, AbstractArray and the iteration protocol. I.e is it ok to segfault if someone implemented the iteration protocol erroneously?
There was a problem hiding this comment.
This is iterating over the index space of a: foreach(i -> a[i] = a[i], eachindex(a)). I think it's OK to assume that is required to hold.
There was a problem hiding this comment.
AFAIK the policy is that AbstractArray implementations which opt-in to using @boundscheck assert that they are correct, so it's OK to crash if that's not the case. See #20469 and linked issues.
| @@ -2345,7 +2345,7 @@ function filter!(f, a::AbstractVector) | |||
|
|
|||
| for acurr in a | |||
| if f(acurr) | |||
| a[i] = acurr | |||
| @inbounds a[i] = acurr | |||
There was a problem hiding this comment.
This is iterating over the index space of a: foreach(i -> a[i] = a[i], eachindex(a)). I think it's OK to assume that is required to hold.
andyferris
force-pushed
the
ajf/inbounds-filter
branch
from
d18cc8f
to
41222bd
Compare
andyferris
force-pushed
the
ajf/inbounds-filter
branch
from
41222bd
to
33e0ffd
Compare
|
Should performance improvements like this one be backported? |
|
Yes |
StefanKarpinski
added
status:triage
KristofferC
removed
backport 1.0
status:triage
No description provided.