Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
lufact for sparse matrix pivot option error (#18246)
* lufact for sparse matrix pivot option error base/sparse/umfpack.jl includes the following method definition for lufact `lufact(A::SparseMatrixCSC, pivot::Type{Val{false}}) = lufact(A)` This should likely be `lufact(A::SparseMatrixCSC, pivot::Type{Val{true}}) = lufact(A)` because in lufact pivoting is on by default. The error is shown in the following example ``` A = speye(4) A[1:2,1:2] = [-.01 -200; 200 .001] F = lufact(A,Val{false}) F[:p] ``` which returns ``` julia> F[:q] 4-element Array{Int64,1}: 3 4 1 2 ``` However it should return ``` julia> F[:q] 4-element Array{Int64,1}: 1 2 3 4 ``` because pivoting was turned off. * Added test for #18246 and #18244 * 4 space indent oops my bad * remove unnecessary lufact method * update test for removed lufact method definition (cherry picked from commit 68d3d32)
- Loading branch information