lufact for sparse matrix pivot option error #18244
Labels
linear algebra
Linear algebra
Comments
|
Thanks for reporting the bug. Could you submit a PR? |
andreasnoack
pushed a commit
that referenced
this issue
Aug 29, 2016
* lufact for sparse matrix pivot option error
base/sparse/umfpack.jl includes the following method definition for lufact
`lufact(A::SparseMatrixCSC, pivot::Type{Val{false}}) = lufact(A)`
This should likely be
`lufact(A::SparseMatrixCSC, pivot::Type{Val{true}}) = lufact(A)`
because in lufact pivoting is on by default.
The error is shown in the following example
```
A = speye(4)
A[1:2,1:2] = [-.01 -200; 200 .001]
F = lufact(A,Val{false})
F[:p]
```
which returns
```
julia> F[:q]
4-element Array{Int64,1}:
3
4
1
2
```
However it should return
```
julia> F[:q]
4-element Array{Int64,1}:
1
2
3
4
```
because pivoting was turned off.
* Added test for #18246 and #18244
* 4 space indent
oops my bad
* remove unnecessary lufact method
* update test for removed lufact method definition
|
Fixed by #18246 |
mfasi
pushed a commit
to mfasi/julia
that referenced
this issue
Sep 5, 2016
* lufact for sparse matrix pivot option error
base/sparse/umfpack.jl includes the following method definition for lufact
`lufact(A::SparseMatrixCSC, pivot::Type{Val{false}}) = lufact(A)`
This should likely be
`lufact(A::SparseMatrixCSC, pivot::Type{Val{true}}) = lufact(A)`
because in lufact pivoting is on by default.
The error is shown in the following example
```
A = speye(4)
A[1:2,1:2] = [-.01 -200; 200 .001]
F = lufact(A,Val{false})
F[:p]
```
which returns
```
julia> F[:q]
4-element Array{Int64,1}:
3
4
1
2
```
However it should return
```
julia> F[:q]
4-element Array{Int64,1}:
1
2
3
4
```
because pivoting was turned off.
* Added test for JuliaLang#18246 and JuliaLang#18244
* 4 space indent
oops my bad
* remove unnecessary lufact method
* update test for removed lufact method definition
tkelman
pushed a commit
that referenced
this issue
Feb 22, 2017
* lufact for sparse matrix pivot option error
base/sparse/umfpack.jl includes the following method definition for lufact
`lufact(A::SparseMatrixCSC, pivot::Type{Val{false}}) = lufact(A)`
This should likely be
`lufact(A::SparseMatrixCSC, pivot::Type{Val{true}}) = lufact(A)`
because in lufact pivoting is on by default.
The error is shown in the following example
```
A = speye(4)
A[1:2,1:2] = [-.01 -200; 200 .001]
F = lufact(A,Val{false})
F[:p]
```
which returns
```
julia> F[:q]
4-element Array{Int64,1}:
3
4
1
2
```
However it should return
```
julia> F[:q]
4-element Array{Int64,1}:
1
2
3
4
```
because pivoting was turned off.
* Added test for #18246 and #18244
* 4 space indent
oops my bad
* remove unnecessary lufact method
* update test for removed lufact method definition
(cherry picked from commit 68d3d32)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
base/sparse/umfpack.jl includes the following method definition for lufact
lufact(A::SparseMatrixCSC, pivot::Type{Val{false}}) = lufact(A)This should likely be
lufact(A::SparseMatrixCSC, pivot::Type{Val{true}}) = lufact(A)because in lufact pivoting is on by default.
The error is shown in the following example
which returns
However it should return
because pivoting was turned off.
The text was updated successfully, but these errors were encountered: