Skip to content

Commit

Permalink
Merge pull request #25022 from JuliaLang/yyc/mpfr-nopatch
Browse files Browse the repository at this point in the history
Revert "Add patch to MPFR version (#23287)"
  • Loading branch information
yuyichao authored Dec 13, 2017
2 parents 67ba7bc + 0937ba0 commit 87c1d4f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
7 changes: 2 additions & 5 deletions base/mpfr.jl
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,8 @@ import Base.Math.lgamma_r

import Base.FastMath.sincos_fast

function version()
version = unsafe_string(ccall((:mpfr_get_version,:libmpfr), Ptr{Cchar}, ()))
build = replace(unsafe_string(ccall((:mpfr_get_patches,:libmpfr), Ptr{Cchar}, ())), ' ', '.')
isempty(build) ? VersionNumber(version) : VersionNumber(version * '+' * build)
end
version() = VersionNumber(unsafe_string(ccall((:mpfr_get_version,:libmpfr), Ptr{Cchar}, ())))
patches() = split(unsafe_string(ccall((:mpfr_get_patches,:libmpfr), Ptr{Cchar}, ())),' ')

function __init__()
try
Expand Down
2 changes: 1 addition & 1 deletion test/mpfr.jl
Original file line number Diff line number Diff line change
Expand Up @@ -865,7 +865,7 @@ end
end
end
# issue #22758
if MPFR.version() > v"3.1.5" || "r11590" in MPFR.version().build
if MPFR.version() > v"3.1.5" || "r11590" in MPFR.patches()
setprecision(2_000_000) do
@test abs(sin(big(pi)/6) - 0.5) < ldexp(big(1.0),-1_999_000)
end
Expand Down

1 comment on commit 87c1d4f

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

Please sign in to comment.